445376 - In </toolkit/*>, "use a xul <stringbundle/> instead of including the strres.js code"

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[Serge Gautherie (:sgautherie)]

{{
/toolkit/components/printing/content/printdialog.xul
    * line 58 -- <script type="application/javascript" src="chrome://global/content/strres.js"/>

/toolkit/components/printing/content/printjoboptions.xul
    * line 55 -- <script type="application/javascript" src="chrome://global/content/strres.js"/>
}}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <print*.*> [Checkin: Comment 7]

(untested, as I have no printer)

Comment 2

[Serge Gautherie (:sgautherie)]

mano, ping ?

Comment 3

[Neil Deakin]

Comment on attachment 331888 [details] [diff] [review]
(Av1) <print*.*>
[Checkin: Comment 7]

Looks OK, but you should e able to test it even without a printer.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 331888 [details] [diff] [review]
(Av1) <print*.*>
[Checkin: Comment 7]

(In reply to comment #3)
> you should e able to test it even without a printer.

How ?

Page Setup... : (works)
Print Preview: "Print Preview Error / ... one printer available ..."
Print: "About - Minefield / ... you must install a printer ..." (in French)

Comment 5

[Neil Deakin]

Can you not just set up a printer even if one isn't physically present?

How do these dialogs get shown?

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> Can you not just set up a printer even if one isn't physically present?

I don't know and won't mess with that :-|

> How do these dialogs get shown?

As far as I remember, I started to look for the "chrome uri",
then gave up as (I assume) I would not have any printer/data to feed them anyway.

Comment 7

[Reed Loden [:reed]]

Pushed as 17118:eb38af6bfdf1.

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080917032624 Minefield/3.1b1pre] (home, optim default) (W2Ksp4)

I wanted to test this now, as I have installed the "doPDF" driver in the meantime.

But it seems these dialogs are only available in non-MacOSX unixes (or Calendar):
http://mxr.mozilla.org/comm-central/search?string=printdialog\.xul&regexp=1
http://mxr.mozilla.org/mozilla-central/search?string=printjoboptions%5C.xul&regexp=on&case=on

As I don't have any of the two, someone else would have to do it :-|