pushlog contains 'None' at the end of the file causing HgPoller to barf

RESOLVED FIXED

Status

Release Engineering
General
--
critical
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: ted)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Getting tracebacks like this:
2008/07/16 03:38 PDT [-] Hg poll failed: [Failure instance: Traceback: <class 'xml.parsers.expat.ExpatError'>: junk after document element: line 141, column 16
        /tools/twisted-2.4.0/lib/python2.5/site-packages/twisted/internet/defer.py:107:maybeDeferred
        /tools/buildbotcustom/buildbotcustom/changes/hgpoller.py:194:poll
        /tools/twisted-2.4.0/lib/python2.5/site-packages/twisted/internet/defer.py:191:addCallback
        /tools/twisted-2.4.0/lib/python2.5/site-packages/twisted/internet/defer.py:182:addCallbacks
        --- <exception caught here> ---
        /tools/twisted-2.4.0/lib/python2.5/site-packages/twisted/internet/defer.py:307:_runCallbacks
        /tools/buildbotcustom/buildbotcustom/changes/hgpoller.py:244:_process_changes
        /tools/buildbotcustom/buildbotcustom/changes/hgpoller.py:225:_parse_changes
        /tools/python-2.5.1/lib/python2.5/xml/dom/minidom.py:1923:parseString
        /tools/python-2.5.1/lib/python2.5/xml/dom/expatbuilder.py:940:parseString
        /tools/python-2.5.1/lib/python2.5/xml/dom/expatbuilder.py:223:parseString


And here's the last line of pushlog:
 </entry></feed>None
(Assignee)

Comment 1

10 years ago
*sigh* Sorry about that. I'll figure out what's going on here.
Assignee: nobody → ted.mielczarek
(Assignee)

Comment 2

10 years ago
Created attachment 329814 [details] [diff] [review]
fix pushlog feed

Stupid, I made a change when I switched to using a template for the html output, but it broke the feed output, since that's not using a template. Didn't notice it here, I must be running a different version of Mercurial than hg.mozilla.org.

Pushed:
http://hg.mozilla.org/users/bsmedberg_mozilla.com/hgpoller/index.cgi/rev/d4bf9acf1959
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

10 years ago
Filed bug 445484 on getting this deployed.
Product: mozilla.org → Release Engineering

Comment 4

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/82bbc9fdbfc6
You need to log in before you can comment on or make changes to this bug.