445473 - Ctrl+Tab panel layout update

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[u88484]

The new ctrl+tab panel's favicons are distorted.  Not just because they are enlarged but also some weird diagonal stretching or something to that effect.  At least losing the diagonal stretch would make them look a little better.

Comment 1

[nightstalkerz]

I think just displaying the icons normally without stretching them would be fine.

Comment 2

[Dão Gottwald [:dao]]

Attachment: smaller and non-skewed favicons, thinner panel border, slightly bigger previews

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As I can see from the last attachment the mirror effect also shows a squeezed tab preview. Is it an expected behavior? At least on OS X it isn't working that way. Probably this should be filed as a new bug if it doesn't exist yet.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> As I can see from the last attachment the mirror effect also shows a squeezed
> tab preview. Is it an expected behavior?

Yes. I don't know of any reports that this isn't working on OS X, so please file a bug.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 331530 [details]
smaller and non-skewed favicons, thinner panel border, slightly bigger previews

Yeah, this is fine with me. IIRC we started with the skew as part of some up-sampling work on favicons that would make them look like 8-bit graphics - as long as they're clearly distinct from page elements. This ends up looking a little cleaner to my eye as well.

Comment 7

[Dão Gottwald [:dao]]

Attachment: full patch

Not all of this patch is strictly related to this bug, but beltzner reviewed this while he was at it (the screenshot shows all the changes).

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/0e5d942b54be

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080822021301 Minefield/3.1a2pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a2pre) Gecko/20080823032129 Minefield/3.1a2pre ID:20080823032129

Dao, as I can see the size of the previews is calculated by the current screen size settings during the initialization (startup of Firefox). If users change the settings while Firefox is up the size of the tab-panel and the previews don't change their size. Is it something which could be fixed? If yes, I would file a new bug.

Comment 10

[Dão Gottwald [:dao]]

Yes, that could be fixed. I'm not sure if it's worthwhile.