Ctrl+Tab panel layout update

VERIFIED FIXED in Firefox 3.1a2

Status

()

enhancement
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: u88484, Assigned: dao)

Tracking

Trunk
Firefox 3.1a2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

11 years ago
The new ctrl+tab panel's favicons are distorted.  Not just because they are enlarged but also some weird diagonal stretching or something to that effect.  At least losing the diagonal stretch would make them look a little better.
(Assignee)

Updated

11 years ago
Keywords: uiwanted
(Reporter)

Updated

11 years ago
Blocks: 395980

Comment 1

11 years ago
I think just displaying the icons normally without stretching them would be fine.
(Assignee)

Updated

11 years ago
Assignee: nobody → dao
As I can see from the last attachment the mirror effect also shows a squeezed tab preview. Is it an expected behavior? At least on OS X it isn't working that way. Probably this should be filed as a new bug if it doesn't exist yet.
(Assignee)

Comment 4

11 years ago
(In reply to comment #3)
> As I can see from the last attachment the mirror effect also shows a squeezed
> tab preview. Is it an expected behavior?

Yes. I don't know of any reports that this isn't working on OS X, so please file a bug.
(Assignee)

Comment 5

11 years ago
Posted patch patch (obsolete) — Splinter Review
(Assignee)

Updated

11 years ago
Attachment #331530 - Attachment description: make favicons a bit smaller (relatively to the screenshot size), don't skew them → make favicons a bit smaller (relative to the screenshot size), don't skew them
Comment on attachment 331530 [details]
smaller and non-skewed favicons, thinner panel border, slightly bigger previews

Yeah, this is fine with me. IIRC we started with the skew as part of some up-sampling work on favicons that would make them look like 8-bit graphics - as long as they're clearly distinct from page elements. This ends up looking a little cleaner to my eye as well.
Attachment #331530 - Attachment description: make favicons a bit smaller (relative to the screenshot size), don't skew them → make favicons a bit smaller (relatively to the screenshot size), don't skew them
Attachment #331530 - Flags: ui-review?(beltzner) → ui-review+
(Assignee)

Comment 7

11 years ago
Posted patch full patchSplinter Review
Not all of this patch is strictly related to this bug, but beltzner reviewed this while he was at it (the screenshot shows all the changes).
Attachment #333212 - Attachment is obsolete: true
Attachment #333574 - Flags: review?(gavin.sharp)
(Assignee)

Updated

11 years ago
Attachment #331530 - Attachment description: make favicons a bit smaller (relatively to the screenshot size), don't skew them → smaller and non-skewed favicons, thinner panel border, slightly bigger previews
(Assignee)

Updated

11 years ago
Keywords: uiwanted
(Assignee)

Updated

11 years ago
Severity: normal → enhancement
Summary: Ctrl+Tab panel favicons are distorted → Ctrl+Tab panel layout update
Attachment #333574 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 8

11 years ago
http://hg.mozilla.org/index.cgi/mozilla-central/rev/0e5d942b54be
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080822021301 Minefield/3.1a2pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a2pre) Gecko/20080823032129 Minefield/3.1a2pre ID:20080823032129

Dao, as I can see the size of the previews is calculated by the current screen size settings during the initialization (startup of Firefox). If users change the settings while Firefox is up the size of the tab-panel and the previews don't change their size. Is it something which could be fixed? If yes, I would file a new bug.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 10

11 years ago
Yes, that could be fixed. I'm not sure if it's worthwhile.
You need to log in before you can comment on or make changes to this bug.