Closed Bug 445527 Opened 12 years ago Closed 12 years ago
Some keyboard shortcuts are not shown in menu
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52pre) Gecko/2008071520 Calendar/0.9pre Steps to Reproduce: 1. Start Sunbird 2. Open File menu and Edit menu Actual Results: 'New Event...', 'New Task...' don't show the corresponding keyboard shortcut. A debug build shows the following console messages: WARNING: Key 'new_todo_key' of menu item 'New Task...' could not be found: file e:/.../mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 1045 WARNING: Key 'new_event_key' of menu item 'New Event...' could not be found: file e:/.../mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 1045 WARNING: Key 'delete_key' of menu item 'Delete Selected Events' could not be found: file e:/.../mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 1045 Expected Results: Menu entries shows keyboard shortcuts like in Sunbird 0.8. I'm not sure if 'Delete Selected Events' showed a keyboard shortcut in the past but 'New Event...', 'New Task...' showed 'Ctrl+N' and 'Ctrl+T'.
This patch fixes the regression from Bug 430430. Also makes the menu entries IDs unique in case someone wants to access them.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #329853 - Flags: review?(philipp)
Comment on attachment 329853 [details] [diff] [review] Fix IDs Thanks for the patch r=philipp
Attachment #329853 - Flags: review?(philipp) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Cehcked in sunbird 20080728 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.