445527 - Some keyboard shortcuts are not shown in menu

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17pre) Gecko/2008071520 Calendar/0.9pre

Steps to Reproduce:
1. Start Sunbird
2. Open File menu and Edit menu

Actual Results:
'New Event...', 'New Task...' don't show the corresponding keyboard shortcut.

A debug build shows the following console messages:

WARNING: Key 'new_todo_key' of menu item 'New Task...' could not be found: file e:/.../mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 1045

WARNING: Key 'new_event_key' of menu item 'New Event...' could not be found: file e:/.../mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 1045

WARNING: Key 'delete_key' of menu item 'Delete Selected Events' could not be found: file e:/.../mozilla/layout/xul/base/src/nsMenuFrame.cpp, line 1045

Expected Results:
Menu entries shows keyboard shortcuts like in Sunbird 0.8. I'm not sure if 'Delete Selected Events' showed a keyboard shortcut in the past but 'New Event...', 'New Task...' showed 'Ctrl+N' and 'Ctrl+T'.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: Fix IDs

This patch fixes the regression from Bug 430430. Also makes the menu entries IDs unique in case someone wants to access them.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 329853 [details] [diff] [review]
Fix IDs

Thanks for the patch r=philipp

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 4

[Andreas Treumann]

Cehcked in sunbird 20080728 -> VERIFIED