44558 - Regression: Back button does not work at all with blank start page

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Stephen Ostermiller]

In todays nightly build the back button is disabled.  It remains greyed out even
after visiting multiple sites.  This does not appear to be related to frames or
any other open bugs involving the back button that I was able to find.

Comment 1

[Sebastian Späth]

*** Bug 44554 has been marked as a duplicate of this bug. ***

Comment 2

[Blake Ross]

reassigning to history

confirming...Alec commented on this on IRC, and there's a dup.  I believe it's 
pp linux...this is a smoketest blocker.

Comment 3

[Blake Ross]

nominating dogfood for obvious reasons...

Comment 4

[Radha on family leave (not reading bugmail)]

I guess windows looks OK. The problem is only in linux? How about Mac? Claudius 
can you update me? There is no platform specific code in the "SH in 
frames" feature I enabled over the weekend. My today morning's windows build 
looks good. Pulling in linux right now

Comment 5

[Blake Ross]

No mac nightlies were made today...and yep, this seems to work fine on win32.

Comment 6

[Jay Patel [:jay]]

Putting on Putting on [dogfood+] radar.radar.

Comment 7

[don]

This works just fine with my Linux commercial build today even on a bugzilla
page.  Marking WORKSFORME until someone proves me wrong.

Comment 8

[don]

Doh!  OK, really marking it WORKSFORME this time.

Comment 9

[Blake Ross]

welp...alec saw this, tor saw it, the reporter of this bug saw it, and the 
reporter of the dup saw it...so obviously something happened.  Whether or not 
it's fixed I don't know...or maybe it was never in the comm branch?

Comment 10

[tor]

Reopening bug.  I saw this on my morning build and again in the tree I pulled
at about 4pm eastern.  Debug build on solaris/native.  This debug assertion
might from startup might be relevant ("about:blank" is my start page):

Adding url about:blank to SH
###!!! ASSERTION: NS_ENSURE_TRUE(NS_SUCCEEDED(AddChildSHEntry(0 , entry,
mChildOffset))) failed: '(!((AddChildSHEntry(0 , entry, mChildOffset)) &
0x80000000))', file /cs/src/mozilla/mozilla/docshell/base/nsDocShell.cpp, line
3105
###!!! Break: at file /cs/src/mozilla/mozilla/docshell/base/nsDocShell.cpp, line
3105

Comment 11

[Radha on family leave (not reading bugmail)]

rick potts is going to checkin some changes that will take care of the assertion 
in the debug builds.

Comment 12

[don]

Hmmmm, Paul Chen says he had this problem with his mozilla build this morning
but after he deleted his ".mozilla" directory everything worked just fine.  I,
however, didn't have to do this with my commercial build.  Weird.  Maybe it has
something to do with the registry?

BTW, someone please make the assert a separate bug and assing it to rpotts.

Radha, the PDT wants an ETA in the status whiteboard field of all dogfood+
bugs.  Do you have any idea what we should put there?  Especially since (I for
one) have no clue as to what's causing this yet?

Comment 13

[don]

But it looks like Paul Chen's Mac mozilla build from this morning works just
fine, like my Linux commercial build.  Weird.

Comment 14

[tor]

Moving my .mozilla directory aside caused the problem to go away.

Comment 15

[don]

Since there appears to be a workaround (although unpleasant), can we at least
take this off the "blocker" list?

Comment 16

[mozilla]

Removing the following lines from prefs.js lets the back button work again:
user_pref("browser.startup.homepage", "");
user_pref("browser.startup.page", 0);

Hope this helps.

Comment 17

[Blake Ross]

I agree that this is no longer a blocker, especially if the easier workaround 
that [e-mail] provided works.  Lowing severity, if anyone feels 
otherwise please provide a good reason before bumping it back up.

Comment 18

[Stephen Ostermiller]

It does appear to be related to using a blank page for your homepage on
startup.  Removing the lines from your prefs fix the problem.  However, if you
go into the menus and put blank page back as your startup page, the problem
reappears.

The summary should be changed to reflect this.

Comment 19

[Asa Dotzler [:asa]]

This bug affects Mac Mozilla bits from 2000070608.  The removing prefs for
startpage works as a workaround.

Comment 20

[Radha on family leave (not reading bugmail)]

I have a fix for this. Shall checkin when the tree opens.

Comment 21

[Radha on family leave (not reading bugmail)]

This is related to not adding pages like "about:blank" to SH. Once the fix is 
checked in, if blank page is your initial page,  what you will see is,

1)Start browser (see blank page)
2) Load some page. (The back button will be disabled now because this new page 
just replaced about:blank in SH.
3)Load some other page. Now back button will come alive and the SH will have 
entries for page 1 and 2 only, not for about:blank. 

Some may argue that about:blank s'd also be in SH. I think that's a different 
issue.

Comment 22

[Radha on family leave (not reading bugmail)]

fix checked in.

Comment 23

[Claudius Gayle]

VERIFIED Fixed it works just as Radha describes in her last comment.