445610 - TinderboxPrint:s should highlight failures so multiple failures caught faster

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When we print a failed test result using "TinderboxPrint" in the various tests we do on tinderbox, we should put in inside a span that is styled so that it shows up more clearly.

I want this because it helps diagnosing multiple failures.  A cell in the tinderbox waterfall turns orange when it has one or more failures.  When there is more than one failure at the same time, we often fail to notice until after the first failure is fixed ("oh, that didn't make it go green, whoops, there was a second failure the whole time").  We could fix these more quickly if the tinderbox UI made us more likely to notice them.

For example, if the reftests fail on a build, instead of printing just:
  reftest: 1971/3/71
we could print:
  <em style="testfail">reftest: 1971/3/71</em>
where we had style like:
  em.testfail { background: black; color: red; }
then if both reftests and chrome tests failed in the same build, we'd be more likely to notice that there were two separate things failing.

Comment 1

[(not currently active) Ted Mielczarek]

someone suggested at some point that we highlight the failed number in red.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: surround testfail results with em class="testfail"

This should provide the necessary style hook. We'll need to stick the actual style somewhere on tinderbox.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 330025 [details] [diff] [review]
surround testfail results with em class="testfail"

OK

Comment 4

[(not currently active) Ted Mielczarek]

Checked in, going to require another unittest master restart to pick this up, though.