44563 - Optimization: Disable timebomb code for Mozilla

Status: VERIFIED DUPLICATE of bug 57306

(SeaMonkey :: General, defect, P3)

Description

[Ben Bucksch (:BenB)]

Timebombs make no sense in an open-source project. I might want to use an older
build. Why shouldn't I? I posted this question to .seamonkey and .general, but
nobody nad a good answer. So, please disable them. (Leaving the code in the
repository and is completely fine, as vendors might want to use them.)

Comment 1

[Ben Bucksch (:BenB)]

See <news://news.mozilla.org/[e-mail]> for a good reason to
disable them.

Comment 2

[Asa Dotzler [:asa]]

over to [e-mail]

Comment 3

[Doug Turner (:dougt)]

They are controled via prefs.  

marking invalid.

Comment 4

[timeless]

please excuse my ignorance, what prefs? where? how does one go about undoing 
the time bomb? or preventing it from being activated?

Comment 5

[Doug Turner (:dougt)]

http://lxr.mozilla.org/seamonkey/source/xpfe/components/timebomb/nsITimeBomb.idl
#27

Comment 6

[Ben Bucksch (:BenB)]

OK, it doesn't seem to be enabled for Mozilla. That's very good.

But why is it built and run?

I have a

user_pref("timebomb.first_launch_time", "962840675265210");

in my prefs.js, and if I delete it, it is rewritten as soon as I start Mozilla.
Timebombs make no sense for Mozilla and propably also for most commercial stable
releases. Running the code costs unnecessarily time and disk/download footprint.

Adjusting SUMMARY and REOPENing as optimization bug.

Comment 7

[Doug Turner (:dougt)]

always accepting diffs.  

Comment 8

[Doron Rosenberg (IBM)]

adding helpwanted keyword

Comment 9

[Judson Valeski]

we won't need this code in the embedding case either

Comment 10

[Doug Turner (:dougt)]

It *is* optional.

Comment 11

[Judson Valeski]

this code is used from seamonkey's main function (which never gets called for 
embedding) in a component that embedding doesn't load. Taking off embedding 
radar.


-> Trudelle. Peter, we don't want to ship the final product w/ this.

Comment 12

[Peter Trudelle]

i dunno from timebombs, leaf?

Comment 13

[Daniel (Leaf) Nunes]

I believe a timebomb that is so easily disabled is ideal for open source binary
non-final releases. 

If you really, really want to run old builds, you can (with the help of a text
editor).

As for a ``final'' product not having a timebomb; to which final product are you
alluding, jud? the betas? the milestones? The mozilla release (whenever whatever
it will be ships)? I guess i'll agree that the ``real'' mozilla release, if ever
there is one, shouldn't have this.

I guess we can add a configure option/env variable to enable or disable this as
part of the build. Leaving helpwanted keyword, because i'm not going to have
time to make this do the right thing in the short term future.

Comment 14

[Ben Bucksch (:BenB)]

Per jud's comment: rtm

Comment 15

[Jon Granrose]

rtm-

mozilla-specific. timebombs are already disabled in the ns build, we're not
removing the timebomb code from the ns build.  not holding netscape rtm for this
bug.

Comment 16

[Håkan Waara]

I first saw this one today in my prefs.js (created a new profile approx. two 
weeks ago) so obviously it's still added to new profiles. Thus it's not 
disabled.

I think even the words "timebomb" scares the user away. How am I supposed to 
know what a timebomb is, in Mozilla code?

Comment 17

[Marco Bosch]

This bug has been fixed by removing nsTimebomb from the build (see bug 57306)

Comment 18

[Håkan Waara]

true.  cc blake to verify.

Comment 19

[Ben Bucksch (:BenB)]

Hakan, this is not invalid!

Comment 20

[Håkan Waara]

Sorry, doesn't the removal of the timebomb stuff render this bug invalid?

Comment 21

[Ben Bucksch (:BenB)]

No, since the "bug" existed when I filed it. It is WFM, DUP or FIXED (if it is
really fixed).

Comment 22

[Håkan Waara]

Sigh, who cares. The important part is that it's resolved, not how.

Comment 23

[timeless]

We care.

Comment 24

[timeless]

*** This bug has been marked as a duplicate of 57306 ***

Comment 25

[Christian :Biesinger (don't email me, ping me on IRC)]

vrfy