445695 - nsMsgFilterAfterTheFact doesn't use m_searchHits

Status: RESOLVED INVALID

(MailNews Core :: Filters, defect)

Description

[[e-mail]]

Well, it only ever calls Add, GetSize and RemoveAll but you don't need an extra nsMsgKeyArray when you already have an array of the nsMsgDBHdr objects.

I also want to rename m_searchHitHdrs to m_searchHits and make it an nsCOMArray.

Comment 1

[[e-mail]]

(In reply to comment #0)
> I also want to rename m_searchHitHdrs to m_searchHits and make it an nsCOMArray.
Oh, I can't do that, it gets passed to DeleteMessages.

Comment 2

[[e-mail]]

Attachment: WIP

So, since getting the length of an nsIArray isn't cheap (it's worse than an nsISupportsArray...) I replaced the key array with a hit count member.

Comment 3

[[e-mail]]

Comment on attachment 329976 [details] [diff] [review]
WIP

Can't remember why I wrote this but the basic idea hasn't bitrotted even if the patch itself has.

Comment 4

[Kent James (:rkent)]

Attachment: Un-bitrotted version of original patch

Comment 5

[Kent James (:rkent)]

Comment on attachment 529123 [details] [diff] [review]
Un-bitrotted version of original patch

Review of attachment 529123 [details] [diff] [review]:

While m_searchHits was not used at the time the patch was written, subsequent changes added a use (to set the processing flag for move) which is necessary to communicate information about moves to the folder objects. So this patch (and its justification) are no longer valid. Is there any reason still to pursue this?

Comment 6

[[e-mail]]

Fair enough.