Closed Bug 445716 Opened 12 years ago Closed 12 years ago

Vertical and Horizontal panning should "snap" into line, instead of wandering

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0m6

People

(Reporter: johnath, Assigned: johnath)

Details

Attachments

(1 file, 3 obsolete files)

Attached patch 30% cutoff (obsolete) — Splinter Review
It's rare for a panning event to be perfectly vertical or horizontal, even when that's the intent.  We should dump the noise on events that are obviously intended for one axis.

Patch attached using 30% off-axis deviation as the noise threshold.
Attachment #329992 - Flags: review?(gavin.sharp)
gavin pointed out that we should threshold it so that small moves are smooth, not locked in
Assignee: nobody → johnath
Attachment #329992 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #329992 - Flags: review?(gavin.sharp)
I think 40px feels better than 60px on XULRunner, gonna test it on the device itself before asking for review.
Attachment #329995 - Attachment is obsolete: true
Attached patch with faster panning, too (obsolete) — Splinter Review
Pretty!
Attachment #329999 - Attachment is obsolete: true
Comment on attachment 329999 [details] [diff] [review]
40px threshold instead of 60

Asking for review on the one without the better panning redraws, which is now in bug 445734
Attachment #329999 - Attachment is obsolete: false
Attachment #329999 - Flags: review?(gavin.sharp)
Attachment #330008 - Attachment is obsolete: true
Attachment #329999 - Flags: review?(gavin.sharp) → review+
did this get checked in?
Flags: wanted-fennec1.0+
Priority: -- → P2
Target Milestone: --- → Fennec M6
(In reply to comment #5)
> did this get checked in?

Yeah, oops.

changeset:   69:172898ffc8a8
user:        Johnathan Nightingale <johnath@mozilla.com>
date:        Thu Jul 17 15:37:15 2008 +0200
summary:     Vertical and horizontal panning should "snap to" the appropriate axis.  b=445716, r=gavin
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
panning has been reimplemented a few times, verified with beta3
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.