445716 - Vertical and Horizontal panning should "snap" into line, instead of wandering

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect, P2)

Description

[Johnathan Nightingale [:johnath]]

Attachment: 30% cutoff

It's rare for a panning event to be perfectly vertical or horizontal, even when that's the intent.  We should dump the noise on events that are obviously intended for one axis.

Patch attached using 30% off-axis deviation as the noise threshold.

Comment 1

[Johnathan Nightingale [:johnath]]

Attachment: only snap for moves bigger than 60px

gavin pointed out that we should threshold it so that small moves are smooth, not locked in

Comment 2

[Johnathan Nightingale [:johnath]]

Attachment: 40px threshold instead of 60

I think 40px feels better than 60px on XULRunner, gonna test it on the device itself before asking for review.

Comment 3

[Johnathan Nightingale [:johnath]]

Attachment: with faster panning, too

Pretty!

Comment 4

[Johnathan Nightingale [:johnath]]

Comment on attachment 329999 [details] [diff] [review]
40px threshold instead of 60

Asking for review on the one without the better panning redraws, which is now in bug 445734

Comment 5

[Stuart Parmenter]

did this get checked in?

Comment 6

[Johnathan Nightingale [:johnath]]

(In reply to comment #5)
> did this get checked in?

Yeah, oops.

changeset:   69:172898ffc8a8
user:        Johnathan Nightingale <[e-mail]>
date:        Thu Jul 17 15:37:15 2008 +0200
summary:     Vertical and horizontal panning should "snap to" the appropriate axis.  b=445716, r=gavin

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

panning has been reimplemented a few times, verified with beta3