44576 - disable the use of native scrollbars for pr2

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[John Morrison]

(As discussed with Eric). Using native scrollbars with seamonkey is no
longer supported , and the product is currently broken in a number of places
when native scrollbars are enabled (e.g., no left hand tree in the
preferences dialog, various painting problems when using scrollbars with
absolute or fixed position HTML/XML, scrollbars appear in ender-lite based
single-line textfields).

For beta2, the setting of the preference 'nglayout.widget.gfxscrollbars",
false' should be ignored in the CSS frame constructor, and the UI for
changing this preference should be commented out in the debug panel of
preferences (pref-debug.xul). [This requires (a) a one line change in C++
code, and (2) commented out a couple of lines in XUL.]

Nominating nsbeta2 : users who have previously tried PR1 and chose to use
native scrollbars will be confronted by some baffling "bugs" unless this
preference is ignored (i.e., GFX scrollbars must be used). 

[Actually, this currently affects users of the nightlies and milestones, and
"bugs" are being reported, but most users understand the problem when given
the answer, so I'm not in a big hurry to get this done ASAP. However, it must
be done for nsbeta2].

Comment 1

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 2

[John Morrison]

Moving back to nsbeta2+, per PDT meeting this afternoon.
Remove/disable the UI for native scrollbars, and ignore the pref setting
for PR2.

Comment 3

[Eric Vaughan]

fixed

Comment 4

[Eric Vaughan]

fixed

Comment 5

[John Morrison]

Hey Eric ... you need to remove the value "nglayoutWidgetGFXScrollbars" from 
the '_elementIDs' array, otherwise nsWidgetStateManager.js barfs with 
'line 130: elements[i] has no properties'

Comment 6

[John Morrison]

... which prevents one from hitting OK and saving changes when in the Debug
prefs panel.

Comment 7

[Eric Vaughan]

Ok added your fixes and put you as reviewer. Seeing I just did what you said. :)

Comment 8

[John Morrison]

Done! (verified fixed)