Closed Bug 445812 Opened 12 years ago Closed 9 years ago

ignore extensions that people pull in from elsewhere into mozilla-central

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file)

If people pull directories into the extensions/ dir under the mozilla-central tree, it would be good if hg would ignore them on commands like "hg status", etc.
This is quite visible when pulling comm-central, which pull in a couple of those, currently from CVS.
This adds all directories comm-central pulls in right now. I added inspector as a commented-out entry as AFAIK sdwilsh has plans to remove it from mozilla-central soon and people (as well as comm-central) will pull it in from its own hg repo.
Attachment #330065 - Flags: review?(ted.mielczarek)
Comment on attachment 330065 [details] [diff] [review]
add those directories to .hgignore that comm-central pulls in right now

I'm not really a fan of this. I think you should just fix the comm-central build to put this code somewhere in the comm-central repo and build it there, instead of sticking it in mozilla/extensions. TAF/wallet/webdav should all be things you can put in your repo until you get rid of dependencies on them. CZ and Venkman might be a little trickier, but I think you can find a better way than putting them in mozilla/extensions. In any case, it's probably not more than an annoyance right now.
Attachment #330065 - Flags: review?(ted.mielczarek) → review-
Ted, I agree it should be under comm-central; but there is no real easy way at the moment, and I want us to all be under Hg sooner than later.

I'd much rather get us in a state where doing a patch in mozilla-central from a comm-central checkout *doesn't* accidentally have people adding these files to mozilla-central.
I don't see how you'd accidentally add files to mozilla-central, unless you did "hg add" without specifying files explicitly. That's a pretty silly command to run in the first place. Hg won't do anything with non-version-controlled files, they'll just show up with a ? in "hg status", which might be annoying, but isn't dangerous.
I've heard of some using |hg addremove| when importing patches from others for push.

It will surely grab these files, and so would a *mistakenly* pressed |hg add| rather than simply |hg add <files>| and recovering from mistakes in hg is sadly not as easy as in CVS (so some may not know the answers well).

Is there so much harm in temporarily putting these in .hgignore?
Comment on attachment 330065 [details] [diff] [review]
add those directories to .hgignore that comm-central pulls in right now

>+extensions/venkman/
>+extensions/typeaheadfind/

In case it's accepted, you might want to swap the order of these two.
(In reply to comment #6)
> In case it's accepted, you might want to swap the order of these two.

No.
The first ones are there to stay, the latter three will be rendered obsolete with further work on the code.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.