445828 - Trying to re-init a TYPE_REPEATING_SLACK timer causes it to be added to timer thread twice

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

jst found this while reviewing bug 437152. Trying to re-init a TYPE_REPEATING_SLACK timer causes it to be added to timer thread twice. Patch attached that removes a previous instance from the timer thread if it is reinitialized.

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 330083 [details] [diff] [review]
Patch, v1

Did you confirm that the callback added the timer again? Isn't that a bug at some level (if the type is repeating)?

/be

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

My case was a TYPE_ONE_SHOT timer reinitializing as a TYPE_REPEATING_SLACK. By the time we get to the code in question InitCommon has already updated mType.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

Actually, brendan, I think this patch is better. What do you think?

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 330569 [details] [diff] [review]
Patch, v2

Yes, that is better.

/be

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pushed to moz-central.