445845 - opening a new link from a full screen flash site doesn't focus the window where the tab was opened

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[zahari tzigularov]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_4; en-us) AppleWebKit/525.18 (KHTML, like Gecko) Version/3.1.2 Safari/525.20.1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0

when viewing a flash site in full screen, any external links from the site open as a tab in the previous window so they end up displaying behind the full screen.  you have to minimize or close the full-screen in order to see the new page.

Reproducible: Always

Steps to Reproduce:
1. go to http://blusites.com/betsey/
2. click on the "flash" link - full screen flash site displays
3. click on the blog link
Actual Results:  
the new page displays behind the site as a tab in the previous window

Expected Results:  
the new page displays on top of the full screen window

Comment 1

[Ria Klaassen (not reading all bugmail)]

This regressed on 16 Jan 2008 from bug 377551.

Comment 2

[Nochum Sossonko [:Natch]]

see bug 439054 similar/dupe.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Connor: as with bug 439054, moving this to P1 - feel free to dupe it if you see fit.

Comment 4

[Mike Connor [:mconnor]]

Yeah, this one's straightforward, we don't actually focus the window if it's not focused.  The helper needs to pass this back, but it's a private method so no one gets to complain if I change it to return an array (win and topmost).

Comment 5

[Mike Connor [:mconnor]]

Attachment: focus window if we're opening a link in a different window

pretty straightforward

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 356933 [details] [diff] [review]
focus window if we're opening a link in a different window

your .hgrc needs
[defaults]
diff=-p -U 8
! :)

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 356933 [details] [diff] [review]
focus window if we're opening a link in a different window

Huh, you're right.  Fixed!

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 356933 [details] [diff] [review]
focus window if we're opening a link in a different window

bah, right.

Comment 9

[Mike Connor [:mconnor]]

Fixed on 1.9.1 and trunk.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 356933 [details] [diff] [review]
focus window if we're opening a link in a different window

needToFocusWin is not declared this way. var win, needToFocusWin; would have worked.

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090511 Minefield/3.6a1pre ID:20090511031307

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090511 Shiretoko/3.5b5pre ID:20090511031352