Closed Bug 445901 Opened 16 years ago Closed 16 years ago

Always select gvar ops for declared global vars, instead of only if loopy/enough-used.

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1a1

People

(Reporter: sayrer, Assigned: brendan)

Details

Attachments

(1 file, 2 obsolete files)

fix latent bug that loopyGlobal heuristic saved us from
7.87 KB, patch
shaver
: review+
Details | Diff | Splinter Review 
See TM changeset 16320:583c987bc843
Oops, that's 

TM changeset 16318:3323ff68133f
Assignee: general → brendan
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9.1a1

        Attachment #330179 -
        Flags: review?(shaver)

    
    

    
  
Comment on attachment 330179 [details] [diff] [review]
remove loopyGlobal heuristics limiting gvar selection

r=shaver.

        Attachment #330179 -
        Flags: review?(shaver) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        also remove js_IsGlobalReference (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #330179 -
        Attachment is obsolete: true

        Attachment #330513 -
        Flags: review?(shaver)

    
    

    
  
Comment on attachment 330513 [details] [diff] [review]
also remove js_IsGlobalReference

r=shaver, happy for the slight compilation-speed win too

        Attachment #330513 -
        Flags: review?(shaver) → review+

    
    

    
  


  
The testsuite caught this, specifically js1_5/Scope/regress-185485.js. Oh, the horror of this *ancient* latent bug, which certainly could bite loopy global script that uses names in with statements that should bind to the with object, not to a gvar!

/be

        Attachment #330513 -
        Attachment is obsolete: true

        Attachment #330621 -
        Flags: review?(shaver)

    
    

    
  
Comment on attachment 330621 [details] [diff] [review]
fix latent bug that loopyGlobal heuristic saved us from

r=shaver, yay for tests!

        Attachment #330621 -
        Flags: review?(shaver) → review+

    
    

    
  
so is bug 446426 a dupe of this?

    
    

    
  
Fixed:

changeset:   16096:d44c2c61276f
tag:         tip
user:        Brendan Eich <brendan@mozilla.org>
date:        Mon Jul 21 15:14:14 2008 -0700
summary:     Always select gvar ops for declared global vars, instead of only if loopy/enough-used (445901, r=shaver).

/be
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Flags: in-litmus-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: