445934 - Layout linking broken in NS_OSSO disable-libxul configuration

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Fast fix

Building of latest trunk in maemo scratchbox + --disable-libxul  broken because missing linking options..

Also I think NS_OSSO define is wrong for location and gpsbt compilation, because NS_OSSO check for libosso dependency.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 330186 [details] [diff] [review]
Fast fix

seems safe and reasonable.  ted is the right guy, though.

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: MOZ_LOCATION NS_MAEMO_LOCATION defines

This is second part. Need to be applied after first patch.
 
I don't think that we need separate bug for this fix.... but if we need I can create new bug.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 330191 [details] [diff] [review]
MOZ_LOCATION NS_MAEMO_LOCATION defines

clearly this is a seperate issue and has nothing to do with NS_OSSO.  Please file a seperate bug regarding disabling MOZ_OJI.  The patch looks fine, assuming it works.

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Right patch about NS_MAEMO_LOCATION defines...

Ups... previous patch was wrong...

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 330194 [details] [diff] [review]
Right patch about NS_MAEMO_LOCATION defines...

i am confused about hildon, osso, and maemo

should this be NS_OSSO_LOCATION

and, can you ever have and osso distribution without location apis?

Comment 6

[Oleg Romashin (:romaxa)]

> i am confused about hildon, osso, and maemo
> 
> should this be NS_OSSO_LOCATION
No, location is mostly related to Maemo platform...

OSSO - as name almost dead...

Hildon - is layer on top of GTK, should be used in case of Input Method, Theeming, ....

> 
> and, can you ever have and osso distribution without location apis?

I think there are no such entity as "osso distribution", there are Maemo Software.

See: https://wiki.maemo.org/Maemo_summit_2008


> 

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 330186 [details] [diff] [review]
Fast fix

I don't really like this patch.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 330194 [details] [diff] [review]
Right patch about NS_MAEMO_LOCATION defines...

I like this patch.

Comment 9

[Oleg Romashin (:romaxa)]

Can we check in this?

Comment 10

[Justin Dolske [:Dolske]]

Ted: do you want to / need to SR this? You sr-'d the first version, but only r+'d the last...

Comment 11

[Reed Loden [:reed]]

Ted isn't a super-reviewer.

Comment 12

[Reed Loden [:reed]]

However, since this is mostly build-related stuff, his r+ might be enough.

Comment 13

[Reed Loden [:reed]]

This patch is bitrotted... please unbitrot it. :)

Comment 14

[Oleg Romashin (:romaxa)]

Attachment: Updated to trunk. ready to commit

Comment 15

[Oleg Romashin (:romaxa)]

Comment on attachment 337646 [details] [diff] [review]
Updated to trunk. ready to commit

Ups, this is not ready yet.
+ifdef NS_MAEMO_LOCATION
 CPPSRCS		+= MaemoLocationProvider.cpp
 LOCAL_INCLUDES	+= $(MOZ_GTK2_CFLAGS)

s/MOZ_GTK2_CFLAGS/MOZ_LOCATION_CFLAGS/

Comment 16

[Oleg Romashin (:romaxa)]

Attachment: Ready to commit +comment 15

Comment 17

[(not currently active) Ted Mielczarek]

Comment on attachment 337653 [details] [diff] [review]
Ready to commit +comment 15

build stuff doesn't need sr.

Comment 18

[Oleg Romashin (:romaxa)]

Fixed:
http://hg.mozilla.org/mozilla-central/rev/d07d215cf20f