445995 - Event dialog also contains elements from task dialog

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Pete Riley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16
Build Identifier: Lightning 0.9pre 2008-07-17 19 / Thunderbird 2.0.0.14

Event dialog also contains elements from task dialog.

Error: documentButton has no properties
Source File: chrome://calendar/content/sun-calendar-event-dialog.js
Line: 2327

Using Windows XP (classic theme)

Reproducible: Always

Steps to Reproduce:
1) In Lightning, double click in an empty part of a day in month view


Actual Results:  
The event dialog also contains elements from the task dialog.

After I close the dialog, the "busy cursor" remains.

Expected Results:  
The event dialog should only be the event dialog, and the cursor should be normal after I close the event dialog.

Comment 1

[Martin Schröder [:mschroeder]]

WFM using Lightning 0.9pre (2008071719) on WinXP.

Pete, what elements from the Task dialog do you see there?

Comment 2

[Pete Riley]

Attachment: Screenshot of event & task dialogs mixed together

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, this often happens on javascript errors. This is my regression.

Comment 4

[Stefan Sitter [:ssitter]]

Confirmed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17pre) Gecko/20080717 Calendar/0.9pre.

Steps to Reproduce:
1. Open event/task dialog
2. In the dialog select View -> Toolbars -> Customize 
3. Remove the Attach button from the toolbar
4. Close and reopen the event/task dialog.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix v1

Hmm...I believe berend is on vacation, who's up for review? ssitter, mschroeder please take over if you like.

Comment 6

[Stefan Sitter [:ssitter]]

Comment on attachment 332565 [details] [diff] [review]
Fix v1

> function updateAttachment() {
>     var hasAttachments = capSupported("attachments");
>     setElementValue("cmd_attach_url", !hasAttachments && "true", "disabled");

Patch seems to work fine but doesn't this line above the changes already do the same?

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix v2

Yes, good catch, thanks!

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 332662 [details] [diff] [review]
Fix v2

r=ssitter

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 10

[Andreas Treumann]

Checked in lightning 2008081018 and sunbird 20080811 -> VERIFIED

Comment 11

[Pete Riley]

Since I opened this bug, I'll also confirm that it's fixed.  Thanks!