Closed
Bug 445995
Opened 16 years ago
Closed 16 years ago
Event dialog also contains elements from task dialog
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: mozilla, Assigned: Fallen)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
90.88 KB,
image/gif
|
Details | |
1.67 KB,
patch
|
ssitter
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16 Build Identifier: Lightning 0.9pre 2008-07-17 19 / Thunderbird 2.0.0.14 Event dialog also contains elements from task dialog. Error: documentButton has no properties Source File: chrome://calendar/content/sun-calendar-event-dialog.js Line: 2327 Using Windows XP (classic theme) Reproducible: Always Steps to Reproduce: 1) In Lightning, double click in an empty part of a day in month view Actual Results: The event dialog also contains elements from the task dialog. After I close the dialog, the "busy cursor" remains. Expected Results: The event dialog should only be the event dialog, and the cursor should be normal after I close the event dialog.
Comment 1•16 years ago
|
||
WFM using Lightning 0.9pre (2008071719) on WinXP. Pete, what elements from the Task dialog do you see there?
Reporter | ||
Comment 2•16 years ago
|
||
Assignee | ||
Comment 3•16 years ago
|
||
Yes, this often happens on javascript errors. This is my regression.
Assignee: nobody → philipp
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-calendar0.9?
Keywords: regression
Updated•16 years ago
|
Flags: blocking-calendar0.9? → blocking-calendar0.9+
Comment 4•16 years ago
|
||
Confirmed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17pre) Gecko/20080717 Calendar/0.9pre. Steps to Reproduce: 1. Open event/task dialog 2. In the dialog select View -> Toolbars -> Customize 3. Remove the Attach button from the toolbar 4. Close and reopen the event/task dialog.
Assignee: philipp → nobody
Component: Lightning Only → General
OS: Windows XP → All
QA Contact: lightning → general
Hardware: PC → All
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 5•16 years ago
|
||
Hmm...I believe berend is on vacation, who's up for review? ssitter, mschroeder please take over if you like.
Attachment #332565 -
Flags: review?(daniel.boelzle)
Comment 6•16 years ago
|
||
Comment on attachment 332565 [details] [diff] [review] Fix v1 > function updateAttachment() { > var hasAttachments = capSupported("attachments"); > setElementValue("cmd_attach_url", !hasAttachments && "true", "disabled"); Patch seems to work fine but doesn't this line above the changes already do the same?
Assignee | ||
Comment 7•16 years ago
|
||
Yes, good catch, thanks!
Attachment #332565 -
Attachment is obsolete: true
Attachment #332662 -
Flags: review?(ssitter)
Attachment #332565 -
Flags: review?(daniel.boelzle)
Comment 8•16 years ago
|
||
Comment on attachment 332662 [details] [diff] [review] Fix v2 r=ssitter
Attachment #332662 -
Flags: review?(ssitter) → review+
Assignee | ||
Comment 9•16 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Comment 10•16 years ago
|
||
Checked in lightning 2008081018 and sunbird 20080811 -> VERIFIED
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 11•16 years ago
|
||
Since I opened this bug, I'll also confirm that it's fixed. Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•