Closed
Bug 446002
Opened 18 years ago
Closed 18 years ago
Tooltips in calendar list always show the first readonly calendar name
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: mozilla, Assigned: Fallen)
Details
Attachments
(1 file)
|
4.32 KB,
patch
|
berend.cornelius09
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16
Build Identifier: Lightning 0.9pre 2008-07-17 19 / Thunderbird 2.0.0.14 / Windows XP (classic theme)
Tooltips in calendar list always show the first readonly calendar name
Reproducible: Always
Steps to Reproduce:
1) In month view, hold mouse over any calendar name in the calendar list
Actual Results:
The tooltip never changes and always shows the name of my first readonly calendar instead of the calendar that's currently under the mouse cursor. Example text: "The calendar X is readonly".
Expected Results:
Besides that the text is wrong, the tooltip seems like an unnecessary annoyance in general since it's obvious in the calendar list (without using a tooltip) which calendars are readonly.
IMO, the tooltip should only contain the name of the calendar, and only be shown when the calendar name is too wide to fit in the list (i.e. when it ends with an ellipsis (...)).
Comment 1•18 years ago
|
||
Confirmed using Lightning 0.9pre (2008071719) on WinXP.
> Tooltips in calendar list always show the first readonly calendar name
I haven't found a logic for the shown tooltip. But if you have multiple readonly calendar the correct tooltip is shown for each of them. The problem only applies to writeable calendars and empty areas in the calendar section.
> 1) In month view, hold mouse over any calendar name in the calendar list
For me this holds true in all calendar views.
Status: UNCONFIRMED → NEW
Component: Calendar Views → General
Ever confirmed: true
QA Contact: views → general
| Assignee | ||
Comment 2•18 years ago
|
||
I can also confirm, Martin's description is correct. If the calendar has no errors, then the message of the last calendar with an error that the mouse hovered over is still shown.
OS: Windows XP → All
Hardware: PC → All
| Assignee | ||
Comment 3•18 years ago
|
||
This is a one-liner, I will probably include this fix in a patch in bug 392561.
Assignee: nobody → philipp
Depends on: 392561
Comment 4•18 years ago
|
||
Issue is still exists using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18pre) Gecko/2008090109 Calendar/0.9pre. The check-in for bug 392561 didn't fixed it.
In addition to the original issue described in comment #0 there is now another issue: If you remove the read-only status from the calendar the tooltip still shows it as read-only. (Regressed between 2008-08-31-18 and 2008-09-01-09 build.)
| Assignee | ||
Comment 5•18 years ago
|
||
I decided to fix this patch a bit differently, so its now more than a one-liner. Instead of composing the tooltip on each mouse movement, I rather used a tooltip element with onpopupshowing.
Attachment #336451 -
Flags: review?(Berend.Cornelius)
Comment 6•18 years ago
|
||
Comment on attachment 336451 [details] [diff] [review]
Fix - v1
patch solves the problem and looks good; r=berend
Attachment #336451 -
Flags: review?(Berend.Cornelius) → review+
| Assignee | ||
Comment 7•18 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH
-> FIXED
Target Milestone: --- → 0.9
| Assignee | ||
Updated•18 years ago
|
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 8•18 years ago
|
||
Checked in lightning build 2008090303 and sunbird 20080902 -> VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•