446221 - can't drag and drop from history to desktop

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ivan Ičin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1

You can drag from Bookmarks menu to desktop and make URL shortcut.

Unfortunatly this is not possible from history in any variant - from History menu, from sidebar or from Library

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Tyler Downer [He/Him]]

Please put steps to reproduce in the bug report. Severity should be changed to Minor.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Regression range is:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1204084320&maxdate=1204087739
-> Bug 385245

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Does not happen on OS X. Looks like a Windows only issue.

Comment 4

[Marco Bonardo [:mak]]

fixed by patch in bug 418671

we had to support "link" drag action

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080920033605 Minefield/3.1b1pre

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Marco, I'm a bit unsure that this is really fixed with your patch on bug 418671. The checkin happened around 2008-09-19 08:49:01 PDT but the issue is already fixed for me with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080917034815 Minefield/3.1b1pre ID:20080917034815.

So was there any concurrent checkin which could have been fixed this bug?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Marco, do we have automated tests for this issue? I don't think so, or? If not it would be great to have it in Litmus.

Comment 7

[Tony Chung [:tchung]]

(In reply to comment #6)
> Marco, do we have automated tests for this issue? I don't think so, or? If not
> it would be great to have it in Litmus.

I think we should have both.  marking in-testsuite flag

Comment 8

[Shawn Wilsher :sdwilsh]

There is currently no way to automate drag and drop

Comment 9

[Tony Chung [:tchung]]

mozmill may be a solution to dnd automation.  More later.

Comment 10

[Marco Bonardo [:mak]]

(In reply to comment #5)
> Marco, I'm a bit unsure that this is really fixed with your patch on bug
> 418671. The checkin happened around 2008-09-19 08:49:01 PDT but the issue is
> already fixed for me with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
> rv:1.9.1b1pre) Gecko/20080917034815 Minefield/3.1b1pre ID:20080917034815.
> 
> So was there any concurrent checkin which could have been fixed this bug?

You're right, it is due bug 356295, checked in on 27 Aug, it changed some code about D&D and my patch started from there. Thank you Henrik.

So, fixed by bug 356295.

Comment 11

[Marco Bonardo [:mak]]

(In reply to comment #9)
> mozmill may be a solution to dnd automation.  More later.

Do we already have automated mozmill tests around? i'd be interested if it can be used to automate Places drag&drop (i'm a abit scaried about correct targetting though).

Comment 12

[Tony Chung [:tchung]]

(In reply to comment #11)
> (In reply to comment #9)
> > mozmill may be a solution to dnd automation.  More later.
> 
> Do we already have automated mozmill tests around? i'd be interested if it can
> be used to automate Places drag&drop (i'm a abit scaried about correct
> targetting though).

Sorry, I take it back. The mozmill automation is unable to handle drag and drop to native OS.  We will need to find another solution for creating tests for this.

Comment 13

[Marco Bonardo [:mak]]

(In reply to comment #12)
> Sorry, I take it back. The mozmill automation is unable to handle drag and drop
> to native OS.  We will need to find another solution for creating tests for
> this.

We still need to find a good test base for all Places drag & drop tests, so if you get some idea please put them in a new bug so we can investigate them and try to create a startgin base for this kind of tests.

Comment 14

[Aakash Desai [:aakashd]]

Test cases were created for regression testing on 3.x test runs.

For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=7496
https://litmus.mozilla.org/show_test.cgi?id=7497

For 3.1,
https://litmus.mozilla.org/show_test.cgi?id=7498
https://litmus.mozilla.org/show_test.cgi?id=7499

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv