446558 - Show tooltips in summary dialog

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

The current attendee/organizer fields show only the name if it is specified by the server. This patch adds a tooltip with name and email and also fixes the focus rectangle to not extend over the whole row.

Comment 1

[Berend Cornelius]

Comment on attachment 330733 [details] [diff] [review]
Fix - v1

Patch works fine. 
I noticed already that there is a lot of common logic of the task view and the calendar-summary-dialog and therefor I decided to apply all my summary dialog fixes also to the task-view (see Bug 396819 – Event Summary Dialog doesn't show important information to user). I think this should be done in this case too. As you told me this patch is a by-product of another patch and therefor I think it is fine for the time being.

>+    if (organizer && organizer.id) {
>+        var email = organizer.id;
>+        var re = new RegExp("^mailto:(.*)", "i");
>+        var matches = re.exec(email);
>+        if (matches) {
>+            email = matches[1];
>+        }
We have this logic also in many places in our project. I think we should some day think about consolidating this, too.

Comment 2

[Christian Jansen]

ui=christian

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

calAttendee has a toString() method that takes care of composing the email string, I've used that. I also tried to create a binding that works for both the organizer label and the listitem labels, but that failed due to other XUL issues. There is a XUL issue with this patch (and v1) too, but see the comments in the patch.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 5

[Andreas Treumann]

Checked in lightning 2008072904 -> VERIFIED