Closed Bug 446558 Opened 12 years ago Closed 12 years ago

Show tooltips in summary dialog

Categories

(Calendar :: Calendar Views, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Fix - v1 (obsolete) β€” β€” Splinter Review
The current attendee/organizer fields show only the name if it is specified by the server. This patch adds a tooltip with name and email and also fixes the focus rectangle to not extend over the whole row.
Attachment #330733 - Flags: ui-review?(christian.jansen)
Attachment #330733 - Flags: review?(Berend.Cornelius)
Comment on attachment 330733 [details] [diff] [review]
Fix - v1

Patch works fine. 
I noticed already that there is a lot of common logic of the task view and the calendar-summary-dialog and therefor I decided to apply all my summary dialog fixes also to the task-view (see Bug 396819 – Event Summary Dialog doesn't show important information to user). I think this should be done in this case too. As you told me this patch is a by-product of another patch and therefor I think it is fine for the time being.

>+    if (organizer && organizer.id) {
>+        var email = organizer.id;
>+        var re = new RegExp("^mailto:(.*)", "i");
>+        var matches = re.exec(email);
>+        if (matches) {
>+            email = matches[1];
>+        }
We have this logic also in many places in our project. I think we should some day think about consolidating this, too.
Attachment #330733 - Flags: review?(Berend.Cornelius) → review+
Attachment #330733 - Flags: ui-review?(christian.jansen) → ui-review+
ui=christian
Attached patch Fix - v2 β€” β€” Splinter Review
calAttendee has a toString() method that takes care of composing the email string, I've used that. I also tried to create a binding that works for both the organizer label and the listitem labels, but that failed due to other XUL issues. There is a XUL issue with this patch (and v1) too, but see the comments in the patch.
Attachment #330733 - Attachment is obsolete: true
Attachment #331475 - Flags: ui-review+
Attachment #331475 - Flags: review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Checked in lightning 2008072904 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.