44664 - Search: No feedback when no hits are found

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Phil Peterson]

Using 2000-07-06-09 commercial build on NT

1. Search Inbox for something which doesn't exist
2. Get "document done" in status bar, but no indication that no hits were found

Expected: some indication that a search happened, and nothing was found.

Seems related to a couple other bugs about reporting the # of hits, but this
makes it look (to me, anyway) like Search doesn't work.

Comment 1

[laurel]

Bug about tally of hits is bug #44054, which was futured.
I assumed tally of hits included "none found" when applicable, but guess it's
now a separate issue.

Comment 2

[Blake Ross]

hmm..I don't think you meant bug 44054, but I can't find what bug you were 
likely talking about.

Comment 3

[Phil Peterson]

I think Laurel meant bug 44354

Comment 4

[scottputterman]

moving to future milestone.

Comment 5

[jglick]

In the UI meeting we had to discuss Search it was agreed:

If no matching search results are found:
1. The statusbar should display the text "No matches found"
2. The Results Thread Pane should display the text:  "No results matching your 
criteria were found."  

1 is a must have, 2 is a nice to have.

Adding mail3 keyword so bug considered for 6.5

Comment 6

[scottputterman]

reassigning to gayatrib

Comment 7

[gayatrib]

Fix in hand. Posting patch. Waiting for review.

Comment 8

[gayatrib]

Attachment: Fix for 44664. It reflects that no matches are found when there are no search hits.

Comment 9

[Scott MacGregor]

Hi Gayatri, quick question for ya. When do we unregister this search results
listener interface that you implemented in JS? I see how we register the
listener on the search session. Do we need to unregister it when the search
window goes away? 

Comment 10

[gayatrib]

I wasn't really sure about this. 

There is another listener, the datasource, that is also resgistered as a 
listener--in setupDatasource() function of SearchDialog.js. But it was never 
unregistered. 

So I wasn't really sure if I'd have to explicitly unregister as a listener, or 
if it happens automatically when the search window goes away.

Comment 11

[Scott MacGregor]

It won't happen automatically actually. I think we should explcility unregister
your listener in the unload handler. What do you think?

Comment 12

[gayatrib]

posting new patch unregistering both listeners in SearchDialog.js

Comment 13

[gayatrib]

Attachment: Added code to unregister listeners.

Comment 14

[Scott MacGregor]

new patch looks great. sr=mscott

Comment 15

[gayatrib]

Fix checked in.

Previously when there were no matches found in a search, the status did not say 
anything. 

Now it says "Searching...." while searching.
Says "No matches found" on an unsuccessful search.
And says "Document: Done" on a successful search--simultaneously 
          displaying results in the threadpane.

Comment 16

[Alec Flett]

in the future, you can you use class variables instead of globals?
basically, instead of
if (gIsSearchHit)

and

gIsSearchHit = true;

 you can store it in a variable local to the notification class, and say
if (this.searchHit)

and
this.searchHit = true;

also, it's usually quite cheap to set a variable to a simple variable like true,
rather than test-and-set, so it's probably just as cheap to say

gIsSearchHit = true;
instead of
if (!gIsSearchHit)
  gIsSearchHit = true;

Comment 17

[gayatrib]

Thank you for the helpful tips alec. I will surely rememeber them for the
future. Would you like me to make these changes and re-checkin?

Comment 18

[laurel]

OK  using nov28 commercial trunk builds. Mac OS 9.0, linux rh6.0, win98