Closed Bug 447 Opened 26 years ago Closed 26 years ago

conversion trouble from int to XP_Bool

Categories

(MozillaClassic Graveyard :: Composer, defect, P3)

Tracking

(Not tracked)

VERIFIED WONTFIX

People

(Reporter: jam, Assigned: Brade)

Details

Created by Kazushi Marukawa (jam@pobox.com) on Friday, June 12, 1998 11:21:07 PM PDT
Additional Details :
This is a patch to fix the calculation of XP_Bool values.
The size of XP_Bool might be equal to the size of char.  It
means that "XP_Bool bClearCellHeight = iMode &
ED_MODE_NO_CELL_HEIGHT;" might be wrong because
ED_MODE_NO_CELL_HEIGHT is equal to 0x0800.

I changed all converting expressions from int to XP_Bool
which I found put them into a following patch.  And I
suggest you to use "expr ? TRUE : FALSE;" form instead of
using "(XP_Bool)int-value" form.

I send a patch to netscape.public.mozilla.patches.  The
message-id is <6lt59a$kpm2@secnews.netscape.com>.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WONTFIX
old bug, old code base. Marking won't fix. Please re-open if I am in error.
Status: RESOLVED → VERIFIED
setting to an approximate milestone so it can be off of the no TFV list
Target Milestone: --- → M12
You need to log in before you can comment on or make changes to this bug.