447042 - Opening DOM Inspector crashes Firefox [@ nsMenuBarX::InsertMenuAtIndex]

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jesse Ruderman]

Attachment: Stack trace from a debug build of Firefox

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1a1pre) Gecko/2008072210 Minefield/3.1a1pre

Opening DOM Inspector from the Tools menu crashes Firefox [@ nsMenuBarX::InsertMenuAtIndex].  This might be a regression from bug 442972, which added nsMenuBarX::InsertMenuAtIndex.

I have DOM Inspector 2.0.0.

Comment 1

[Tyler Downer [He/Him]]

Give steps to reproduce please. I could not confirm this on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008072211 Minefield/3.1a1pre, so it may be only a Mac issue.

Comment 2

[Josh Aas]

Given that stack trace there should be information about an exception printed to your system console right before the crash. Can you paste it here?

Comment 3

[Jesse Ruderman]

2008-07-22 17:44:49.939 firefox-bin[11294] *** Assertion failure in -[GeckoNSMenu insertItem:atIndex:], Menus.subproj/NSMenu.m:527

2008-07-22 17:44:49.939 firefox-bin[11294] Mozilla has caught an Obj-C exception [NSInternalInconsistencyException: Invalid parameter not satisfying: (index >= 0) && (index <= (_itemArray ? CFArrayGetCount((CFArrayRef)_itemArray) : 0))]

2008-07-22 17:44:49.939 firefox-bin[11294] <No stack information available for Obj-C exception>

Comment 4

[Dave Townsend [:mossop]]

For some reason I see a different stack, maybe a different issue?

http://crash-stats.mozilla.com/report/index/7e726cfd-598b-11dd-b6ed-001a4bd43e5c

Comment 5

[Jesse Ruderman]

I got a similarly bogus stack when I used a nightly with breakpad.

Comment 6

[(not currently active) Ted Mielczarek]

Looks like our symbols are busted somehow :-( I'll take a look at that when I get a chance.

Comment 7

[Boris Zbarsky [:bzbarsky]]

This is seriously interfering with day-to-day work on layout bugs for me.  Is there anything I can do to get this addressed?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should back out 442972. I'll do it if no-one gets to it first.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by backing out bug 442972.