447045 - -moz-system-metric selector doesn't update when the theme changes

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Rob Arnold [:robarnold]]

Attachment: v1.0

For instance: -moz-system-metric(windows-default-theme) doesn't update when the user changes themes. All the system metrics depend on nsLookAndFeel which is invalidated when the theme changes.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  nsCSSRuleProcessor::Shutdown();

Seems like we should have a better method name or something, this doesn't make sense as is.

You'll want review from a style system peer (bz or dbaron) anyway.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Rob, it would be nice to have a search before filing new bugs. Thanks.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> Rob, it would be nice to have a search before filing new bugs. Thanks.

I'm quite ok with him filing dups with patches.

Comment 5

[Rob Arnold [:robarnold]]

I don't like having it called Shutdown either, but it does exactly what needs to happen and I didn't want extra code. It's only called from nsLayoutStatics::Shutdown so we could rename it without too much of a problem. I can't think of a good name though.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Reset? Flush?

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'd call it FreeSystemMetrics, since you're depending on that being what it does.

Comment 8

[Rob Arnold [:robarnold]]

Attachment: v1.1

renamed nsCSSRuleProcessor::Shutdown to nsCSSRuleProcessor::FreeSystemMetrics

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 331369 [details] [diff] [review]
v1.1

r+sr=dbaron

Comment 10

[Rob Arnold [:robarnold]]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/867a3ad4cbac

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a2pre) Gecko/20080816032044 Minefield/3.1a2pre ID:20080816032044

Would be nice to have this in Litmus. See bug 431306 comment 3 how testers could verify.