447225 - Actually support --skip-calendar in comm-central's client.py

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Justin Wood (:Callek)]

Attachment: support --skip-calendar

We should actually support --skip-calendar (as advertised in client.py).

Sorry that I missed this in my review.

Comment 1

[Stefan [:stefanh]]

Just passing by and noted a copy & paste error in client.py that you might want to fix (or not) at the same time :

170     if not options.skip_venkman:
171         if os.path.exists(os.path.join(topsrcdir, 'mozilla', 'extensions')):
172           do_cvs_checkout(VENKMAN_DIRS, VENKMAN_CO_TAG, options.cvsroot, options.cvs, 'mozilla')
173         else:
174           print >>sys.stderr, "Warning: mozilla/extensions does not exist, ChatZilla could not be checked out."

Comment 2

[Robert Kaiser]

Comment on attachment 330873 [details] [diff] [review]
support --skip-calendar

This looks basically good, but when changing CVS_DIRS to CALENDAR_DIRS, please also change CVS_CO_TAG to CALENDAR_CO_TAG. And please also fix that c&p error stefan pointed out.

Comment 3

[Justin Wood (:Callek)]

pushing to ssh://hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files

Committed to closed tree in changeset: 2066395d65e6

a+ for closed tree per KaiRo on IRC