447558 - xhydra: changeset cfa2d45b2148 broke mac port

Status: RESOLVED FIXED

Description

[Vlad Sukhoy]

After changeset cfa2d45b2148 in xhydra repository, the mac port is broken. Not sure what happened there.

Comment 1

[Benjamin Smedberg]

by "broke" do you mean it doesn't build, or doesn't work? Can you paste the error messages?

Comment 2

[Benjamin Smedberg]

http://hg.mozilla.org/users/tglek_mozilla.com/index.cgi/dehydra-gcc/rev/cfa2d45b2148

Comment 3

[Vlad Sukhoy]

Created attachment 330878 [details] [diff] [review]
fix

Looks like this is the reason why it broke.

Comment 4

[Vlad Sukhoy]

Treehydra doesn't build and produces the following error: 

cc1plus: warning: command line option "-fnested-functions" is valid for C/ObjC but not for C++
Dehydra didn't find required types needed to generate Treehydra
cc1plus: warning: command line option "-fnested-functions" is valid for C/ObjC but not for C++
In file included from /Users/sukhoy/Mozilla/gcc-dehydra/gcc_42-5531/obj/src/gcc/system.h:43,
                 from gcc_cp_headers.h:16:
/usr/include/stdio.h: In function ‘int __sputc(int, FILE*)’:
/usr/include/stdio.h:388: internal compiler error: Bus error
Please submit a full bug report,

The unit test suite of dehydra fails and produces the following errors:

$ /Users/sukhoy/Mozilla/gcc-dehydra/gcc_42-5531/obj/obj-i686-i686/gcc/cc1plus -quiet -O1 -ftest-coverage -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg=test_copy_ctor.js copy_ctor.cc
copy_ctor.cc: In function ‘int main(int, char**)’:
copy_ctor.cc:22: internal compiler error: Bus error
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://developer.apple.com/bugreporter> for instructions.

and

$ /Users/sukhoy/Mozilla/gcc-dehydra/gcc_42-5531/obj/obj-i686-i686/gcc/cc1plus -quiet -O1 -ftest-coverage -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg=test_using_namespace.js using_namespace.cc
using_namespace.cc: In function ‘void f()’:
using_namespace.cc:5: internal compiler error: Bus error
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://developer.apple.com/bugreporter> for instructions.

Having the above patch applied, these errors no longer happen.

Comment 5

[Benjamin Smedberg]

This appears to be mis-indented.

Comment 6

[Vlad Sukhoy]

Created attachment 330881 [details]
treehydra build and testsuite errors

Please see this attachment for error messages with better indentation.

Comment 7

[(dormant account)]

Comment on attachment 330878 [details] [diff] [review]
fix

Oops. I thought these resolve to the same thing

Comment 8

[Vlad Sukhoy]

Pushed.