Closed Bug 447636 Opened 12 years ago Closed 12 years ago

build editor/ui with Mozilla build system as long as it lives in mozilla/

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file)

On IRC, I was pointed to our current way of building editor/ui being wonky, as its DEPTH makes it point to the Mozilla autoconf.mk but it can end up with setting topsrcdir to the comm top directory (probably when generated via make-makefile) and that makes it pull the comm rules.mk which uses MOZILLA_SRCDIR at a number of places which is not defined by the Mozilla autoconf.mk.

Potentially ending up with a mixed build system calls for trouble, and I wonder a bit that it merely works for us right now.

We should move building of mozilla/editor/ui completely to the Mozilla build system via shifting it around in build.mk so things get stable.

Once bug 445146 gets solved, it can make us build it from our build system as it should be.
This patch moves building of editor/ui to the Mozilla build system for now. This should move back when we move this code to comm-central.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #331137 - Flags: review?(bugzilla)
Comment on attachment 331137 [details] [diff] [review]
move editor/ui to be built with the Mozilla build system for now

r=me and a=me for checkin to closed tree.
Attachment #331137 - Flags: review?(bugzilla) → review+
Thanks, checked in.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
You need to log in before you can comment on or make changes to this bug.