Closed
Bug 447696
Opened 17 years ago
Closed 17 years ago
Fix some issues introduced into pref-viewing_messages by bug 297534
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
|
3.95 KB,
patch
|
Bienvenu
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
When the patch on bug 297534 landed it introduced:
* ignoring of some pref lock statuses
* using UI values instead of pref values
* oncommand on checkbox element rather than onchange on preference element
This patch:
* Moves the oncommand to an onchange on "mailnews.mark_message_read.auto" preference element
* Makes label observe the textbox's disabled attribute
* Makes the textbox a number type one
* Makes UpdateMarkAsReadOptions call UpdateMarkAsReadTextbox with computed argument rather than making it calculate it again
Attachment #331005 -
Flags: superreview?(neil)
Attachment #331005 -
Flags: review?(mnyromyr)
|
||
Updated•17 years ago
|
Attachment #331005 -
Flags: superreview?(neil) → superreview+
Comment on attachment 331005 [details] [diff] [review]
pref-viewing_messages patch v0.1 (Checked in)
Switching review request to bienvenu
Attachment #331005 -
Flags: review?(mnyromyr) → review?(bienvenu)
|
||
Updated•17 years ago
|
Attachment #331005 -
Flags: review?(bienvenu) → review+
Comment on attachment 331005 [details] [diff] [review]
pref-viewing_messages patch v0.1 (Checked in)
Checked into comm-central - changeset 40427aa8f844
Attachment #331005 -
Attachment description: pref-viewing_messages patch v0.1 → pref-viewing_messages patch v0.1 (Checked in)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•