Rerunning configure followed by "make all" forces a rebuild of gfx (but no other module)

RESOLVED FIXED in mozilla1.9.1b1

Status

()

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla1.9.1b1
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This is probably because cairo-features.h.in is treated as a Makefile.in and regenerated by configure, so everything that depends on cairo-features.h has to be rebuilt.

cairo-features.h is generated by config.status which is apparently generated by configure (which is of course generated by autoconf, yay!).

So the way I've chosen to fix this is to modify configure.in save away the old config-features.h and then when the new one is generated, compare it to the old one; if they're identical then we move the old one back over the new one, otherwise we throw the old one away.
Created attachment 331270 [details] [diff] [review]
fix
[Checkin: Comment 3]

Fix as described above.
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #331270 - Flags: superreview?(benjamin)
Attachment #331270 - Flags: review?(benjamin)

Comment 2

10 years ago
Comment on attachment 331270 [details] [diff] [review]
fix
[Checkin: Comment 3]

Ugh, we should really just have autoconf magic for this, considering that we do basically the same thing for mozilla-config.h
Attachment #331270 - Flags: superreview?(benjamin)
Attachment #331270 - Flags: review?(benjamin)
Attachment #331270 - Flags: review+
Pushed 3f3ff0208421
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Blocks: 496236
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Attachment #331270 - Attachment description: fix → fix [Checkin: Comment 3]
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b1
No longer blocks: 496236
You need to log in before you can comment on or make changes to this bug.