Closed Bug 447930 Opened 14 years ago Closed 14 years ago

Rerunning configure followed by "make all" forces a rebuild of gfx (but no other module)

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b1

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

fix [Checkin: Comment 3]
2.40 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
This is probably because cairo-features.h.in is treated as a Makefile.in and regenerated by configure, so everything that depends on cairo-features.h has to be rebuilt.

cairo-features.h is generated by config.status which is apparently generated by configure (which is of course generated by autoconf, yay!).

So the way I've chosen to fix this is to modify configure.in save away the old config-features.h and then when the new one is generated, compare it to the old one; if they're identical then we move the old one back over the new one, otherwise we throw the old one away.
Fix as described above.
Assignee: nobody → roc
Status: NEW → ASSIGNED
Attachment #331270 - Flags: superreview?(benjamin)
Attachment #331270 - Flags: review?(benjamin)
Comment on attachment 331270 [details] [diff] [review]
fix
[Checkin: Comment 3]

Ugh, we should really just have autoconf magic for this, considering that we do basically the same thing for mozilla-config.h
Attachment #331270 - Flags: superreview?(benjamin)
Attachment #331270 - Flags: review?(benjamin)
Attachment #331270 - Flags: review+
Pushed 3f3ff0208421
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: C191ConfSync
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Attachment #331270 - Attachment description: fix → fix [Checkin: Comment 3]
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b1
No longer blocks: C191ConfSync
You need to log in before you can comment on or make changes to this bug.