447930 - Rerunning configure followed by "make all" forces a rebuild of gfx (but no other module)

Status: RESOLVED FIXED

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is probably because cairo-features.h.in is treated as a Makefile.in and regenerated by configure, so everything that depends on cairo-features.h has to be rebuilt.

cairo-features.h is generated by config.status which is apparently generated by configure (which is of course generated by autoconf, yay!).

So the way I've chosen to fix this is to modify configure.in save away the old config-features.h and then when the new one is generated, compare it to the old one; if they're identical then we move the old one back over the new one, otherwise we throw the old one away.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Created attachment 331270 [details] [diff] [review]
fix
[Checkin: Comment 3]

Fix as described above.

Comment 2

[Benjamin Smedberg]

Comment on attachment 331270 [details] [diff] [review]
fix
[Checkin: Comment 3]

Ugh, we should really just have autoconf magic for this, considering that we do basically the same thing for mozilla-config.h

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 3f3ff0208421