448161 - [FIX]"ASSERTION: Must have document!" and crash [@ nsStyleUtil::IsHTMLLink]

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

The testcase triggers a crash [@ nsStyleUtil::IsHTMLLink].  Before the crash, I see an assertion that was added in bug 416317:

###!!! ASSERTION: Must have document!: 'aContent->GetCurrentDoc()', file layout/style/nsStyleUtil.cpp, line 470

I think the crash is also a regression, because I'm seeing it fairly often today and don't remember seeing it earlier.

Comment 1

[Martijn Wargers (dead)]

See http://forums.mozillazine.org/viewtopic.php?f=23&t=765915&sid=093e4fef288ab82ae44017c2c2d7c7da
This is probably also the reason why http://code.google.com/apis/checkout/developer/google_checkout_html_api.html crashes.

http://crash-stats.mozilla.com/report/index/aba903dc-5b6d-11dd-98b0-001a4bd43e5c?p=1
0  	xul.dll  	xul.dll@0x27cd05  	
1 	xul.dll 	RuleProcessorData::RuleProcessorData 	layout/style/nsCSSRuleProcessor.cpp:887
2 	xul.dll 	ElementRuleProcessorData::ElementRuleProcessorData 	layout/style/nsIStyleRuleProcessor.h:163
3 	xul.dll 	nsStyleSet::ResolveStyleFor 	layout/style/nsStyleSet.cpp:661
4 	xul.dll 	nsInspectorCSSUtils::GetStyleContextForContent 	layout/style/nsInspectorCSSUtils.cpp:158
5 	xul.dll 	xul.dll@0x307018 	
6 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
7 	xul.dll 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2393

Comment 2

[Martijn Wargers (dead)]

Perhaps a regression from bug 332148, somehow?

Comment 3

[Egor Pelevin]

This also causes a crash in Google Reader gadget while scrolling through the reading list

http://crash-stats.mozilla.com/report/index/8813833a-5bd0-11dd-8e16-001a4bd43e5c
http://crash-stats.mozilla.com/report/index/44ebc65c-5adc-11dd-841f-001cc4e2bf68

Comment 4

[Vorenus]

The OS should be changed to all. I'm using Vista and I get the same crashes.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I'm hitting this a lot while browsing Facebook.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't crash when getting computed style on a link not in the document

Comment 7

[Boris Zbarsky [:bzbarsky]]

Note that the original testcase basically shows bug 399791 in addition to this bug.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 331769 [details] [diff] [review]
Don't crash when getting computed style on a link not in the document

r+sr=dbaron

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 12

[Aakash Desai [:aakashd]]

Seeing that there haven't been any duplicate sightings for this issue for 7
months, I'm going to go ahead and verify this unless someone has an issue with
that.