448199 - nsIMsgIdentity should have a UUID member to make it easy to sync

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: add UUIDs for nsIMsgIdentity, v1

Here's a patch.  This version still needs unit tests and a bit of error-checking
cleanup before it's ready for review.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: add UUIDs for nsIMsgIdentity, v2

Now with more error-checking and fewer crashes!  Still needs some more error-checking and tests before it's review ready, though.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: add UUIDs for nsIMsgIdentity, v3

Strip the leading { and trailing } off the generated UUID before saving it.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: add UUIDs for nsIMsgIdentity, v4

Make the trimming of the trailing \} actually work.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 331549 [details] [diff] [review]
add UUIDs for nsIMsgIdentity, v4

Turns out this was the wrong file.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: identity UUID v4

Comment 6

[Wayne Mery (:wsmwk)]

dmose, is this ready for review?

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Good question; I'll need to spend a bit of time looking at it.  If someone else feels like picking this up, dusting it off, and seeing where it's at, that'd be fine by me.

Comment 8

[:aceman]

Dmose, are you still working on this?

Standard8, rkent, would this be even accepted? It looks like it would be needed for Sync feature for TB that we discussed recently.

Comment 9

[Kent James (:rkent)]

I think that UUID features like this are a good thing, so I would be in favor of it.

Unit tests should be pretty simple for this, and could probably just be added to existing tests.

Comment 10

[Josh]

Anyone feel like picking this up? Seems all it requires is a review by someone competent (which unfortunately isn't me).

Comment 11

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Comment 12

[Pander]

Could this issue please be picked up so that Thunderbird Sync comes one step closer?

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: Bug 448199 - Add a unique identifier to nsIMsgIdentity. r=mkmelin

Adds a 'UID' attribute, stored in the identity's preferences as 'uid', just like nsIAbDirectory. If there's no value, a new UUID is created on access.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/71ed8e2c8537
Add a unique identifier to nsIMsgIdentity. r=mkmelin