Last Comment Bug 448323 - certutil -K doesn't report the token and slot names for found keys
: certutil -K doesn't report the token and slot names for found keys
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.12
: All All
: P2 normal (vote)
: 3.12.1
Assigned To: Nelson Bolyard (seldom reads bugmail)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-28 14:34 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2008-08-08 17:04 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (1.27 KB, patch)
2008-07-28 14:34 PDT, Nelson Bolyard (seldom reads bugmail)
julien.pierre: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2008-07-28 14:34:57 PDT
Created attachment 331594 [details] [diff] [review]
patch v1

The command certutil -K -h all 
goes through all the slots, one by one, and for each slot, it reports any 
keys it finds or reports "no keys found" if it finds none.  But it doesn't 
print out the names of the slots and tokens as it goes, so one cannot tell
from the output which token or slot contains each of the listed keys.

The attached patch improves this.
Comment 1 Julien Pierre 2008-07-29 18:47:43 PDT
Comment on attachment 331594 [details] [diff] [review]
patch v1

This is fine, although the PR_fprintf is not really necessary in the else case (slot != NULL) .
Comment 2 Nelson Bolyard (seldom reads bugmail) 2008-08-01 17:50:48 PDT
Questions:
Does certutil -K work (meaningfully) on the 3.11 branch? 
And if so, should this patch be carried back to that branch>
Comment 3 Nelson Bolyard (seldom reads bugmail) 2008-08-08 17:04:37 PDT
cmd/certutil/certutil.c; new revision: 1.141; previous revision: 1.140

Note You need to log in before you can comment on or make changes to this bug.