Closed Bug 448323 Opened 13 years ago Closed 13 years ago

certutil -K doesn't report the token and slot names for found keys

Categories

(NSS :: Tools, defect, P2)

3.12
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.12.1

People

(Reporter: nelson, Assigned: nelson)

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
The command certutil -K -h all 
goes through all the slots, one by one, and for each slot, it reports any 
keys it finds or reports "no keys found" if it finds none.  But it doesn't 
print out the names of the slots and tokens as it goes, so one cannot tell
from the output which token or slot contains each of the listed keys.

The attached patch improves this.
Attachment #331594 - Flags: review?(julien.pierre.boogz)
Comment on attachment 331594 [details] [diff] [review]
patch v1

This is fine, although the PR_fprintf is not really necessary in the else case (slot != NULL) .
Attachment #331594 - Flags: review?(julien.pierre.boogz) → review+
Priority: -- → P2
Questions:
Does certutil -K work (meaningfully) on the 3.11 branch? 
And if so, should this patch be carried back to that branch>
cmd/certutil/certutil.c; new revision: 1.141; previous revision: 1.140
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.