44856 - Shouldn't write to cache stream after cache entry has been marked truncated

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect, P3)

Description

[Matthew Cline]

If the file that you're downloading is larger than the disk cache you
have, then the cache will fill up and the cache entry for the file
will be marked as TRUNCATED_CONTENT in InterceptStreamListener::Read()
in mozilla/netwerk/cache/mgr/nsCachedNetData.cpp.  However, every
time the Read() method is called after that point in the download,
it will call the private write() method again, and it will fail again;
repeated failure can do weird things (see bug 44452).  So, once the
entry is marked truncated, we should never attempt to write to the
cache stream again for that cache entry.  I will attach a patch
which fixes this problem.

Comment 1

[Matthew Cline]

Attachment: Don't write to cache stream after cache entry has been marked truncated

Comment 2

[Matthew Cline]

Accepting bug.

Comment 3

[Gagan]

Matthew did you intend to take this bug over? Its a minus otherwise. 

Comment 4

[neeti]

Cache bugs to Gordon

Comment 5

[neeti]

Cache bugs to Gordon

Comment 6

[Tom Everingham]

old cache bug, should be fixed in the new cache

Comment 7

[Tom Everingham]

verified