448583 - remove isNil function from DownloadUtils.jsm

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Dão Gottwald [:dao]]

There's an "isNil" function in DownloadUtils.jsm that returns "(aArg == null) || (aArg == undefined)", which is pointless since null == undefined. Instead of "if (isNil(foo))", "if (foo == null)" should be used.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Should be reasonable to assume nobody is going to assign undefined to something else in this scope.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 331792 [details] [diff] [review]
v1

r=sdwilsh

Comment 3

[Ed Lee :Mardak]

Attachment: v1.1

No test required?! ;)

Silly do_check_eq doesn't flatten arrays, so [0] !== [0] but [0].toString()s do.

Putting the test with the other DownloadUtils tests..

toolkit/mozapps/downloads/tests/unit/test_undefinedDownloadUtils.js

You've got until the tree goes green to decide if you want to change the name! :p

Comment 4

[Shawn Wilsher :sdwilsh]

ewww name

how about test_unspecified_arguments.js

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/index.cgi/rev/49c8615d5d46

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED via MXR:

isNil

Searching... Pattern too long. Use a maximum 29 characters. No matching files Found one matching line Found 012345678901234567890123456789 matching lines in 012345678901234567890123456789 files Too many hits, displaying the first 1000

No results found