448587 - SJOWs around functions don't resolve the 'prototype' property

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

From XPC_SJOW_GetOrSetProperty:

  // We don't deal with the following properties here.
  if (id == GetRTStringByIndex(cx, XPCJSRuntime::IDX_PROTOTYPE) ||
      id == GetRTStringByIndex(cx, XPCJSRuntime::IDX_TO_STRING)) {
    return JS_TRUE;
  }

jst, do you remember why we do this? This would affect any random 'prototype' property on a wrapped object and it bites us especially when the wrapped function is

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

This would be the obvious fix + a mochitest.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 331786 [details] [diff] [review]
Fix

I really don't remember exactly why that code is there, but I can't really imagine what it'd be needed for here as long as the property does get wrapped etc.

Comment 3

[John J. Barton]

This would be nice for Firebug...

Comment 4

[Benjamin Smedberg]

Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/3c09b73c94ed

Comment 5

[John J. Barton]

Any news on which version of Firefox will have this fix?

Comment 6

[Boris Zbarsky [:bzbarsky]]

See the "target milestone" field?