SJOWs around functions don't resolve the 'prototype' property

RESOLVED FIXED in mozilla1.9.1a2

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

unspecified
mozilla1.9.1a2
x86
Mac OS X
Points:
---
Bug Flags:
wanted1.9.0.x +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [firebug-p2], URL)

Attachments

(1 attachment)

From XPC_SJOW_GetOrSetProperty:

  // We don't deal with the following properties here.
  if (id == GetRTStringByIndex(cx, XPCJSRuntime::IDX_PROTOTYPE) ||
      id == GetRTStringByIndex(cx, XPCJSRuntime::IDX_TO_STRING)) {
    return JS_TRUE;
  }

jst, do you remember why we do this? This would affect any random 'prototype' property on a wrapped object and it bites us especially when the wrapped function is
Created attachment 331786 [details] [diff] [review]
Fix

This would be the obvious fix + a mochitest.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #331786 - Flags: superreview?(bzbarsky)
Attachment #331786 - Flags: review?(jst)
Attachment #331786 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 331786 [details] [diff] [review]
Fix

I really don't remember exactly why that code is there, but I can't really imagine what it'd be needed for here as long as the property does get wrapped etc.
Attachment #331786 - Flags: review?(jst) → review+

Comment 3

10 years ago
This would be nice for Firebug...
Flags: wanted1.9.0.x?
Whiteboard: [firebug-p2]

Comment 4

10 years ago
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/3c09b73c94ed
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2

Comment 5

10 years ago
Any news on which version of Firefox will have this fix?
See the "target milestone" field?
Flags: wanted1.9.0.x? → wanted1.9.0.x+
You need to log in before you can comment on or make changes to this bug.