448600 - should have a pref to disable audio/video support

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P1)

Description

[(not currently active) Ted Mielczarek]

dveditz expressed concern that we should have a way to disable audio/video support via a pref, to allow users to protect themselves in case of known exploits in video backends.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This really needs to be per-decoder.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I guess it could be per-backend.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Let's call the prefs "media.ogg.enabled" and "media.wave.enabled".

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 352653 [details] [diff] [review]
fix

>+    if (IsWaveEnabled()) {
>+      for (PRUint32 i = 0; i < NS_ARRAY_LENGTH(gWaveTypes); i++) {
>+        catMan->AddCategoryEntry("Gecko-Content-Viewers", gWaveTypes[i],
>+                                  "@mozilla.org/content/document-loader-factory;1",
>+                                 PR_FALSE, PR_TRUE, nsnull);

The indentation there is off.

sr=bzbarsky with that fixed

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 85e9faa23436 to trunk

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/316971d9da18

Comment 8

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090512 Shiretoko/3.5b5pre 
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090512 Minefield/3.6a1pre