448729 - Remove xpfe/components/history from trunk

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Joshua Cranmer [:jcranmer]]

While doing some searching to find where mork was still used. Mailnews uses it in only three places, and those are tracked in bug 11050, bug 382876, and bug 418551. The three places outside of mailnews and on mozilla-central are in toolkit history, xpfe history, and toolkit autocomplete (optionally) (?).

XPFE history seems to be essentially a fork of toolkit history. Seamonkey appears to use toolkit history. Therefore XPFE's version should be removed.

Comment 1

[Robert Kaiser]

This depends on the SeaMonkey move to places (bug 382187), but the xpfe cleanup in bug 380786 only concerns dead code, not used code, so removing dependency.

Comment 2

[Robert Kaiser]

Attachment: kill it!

This patch removes xpfe/components/history and hopefully all its usages. I've verified that SeaMonkey trunk builds correctly with this patch on 1.9.1, I'll test with m-c and other apps, but will only report on that if something doesn't work out.

Comment 3

[[e-mail]]

Comment on attachment 351790 [details] [diff] [review]
kill it!

>diff --git a/xpfe/browser/src/Makefile.in b/xpfe/browser/src/Makefile.in
>--- a/xpfe/browser/src/Makefile.in
>+++ b/xpfe/browser/src/Makefile.in
>@@ -58,21 +58,17 @@
> 		  dom \
> 		  content \
> 		  uriloader \
> 		  pref \
> 		  webbrwsr \
> 		  windowwatcher \
> 		  $(NULL)
> 
>-ifdef MOZ_PLACES
> REQUIRES +=	  places
>-else
>-REQUIRES +=	  history
>-endif
Nit: could add places to the main REQUIRES list.

Comment 4

[Robert Kaiser]

Pushed as http://hg.mozilla.org/mozilla-central/rev/8b14f8b9bf02 on trunk and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/021d7e413f8d on branch, with nit addressed.

Comment 5

[Robert Kaiser]

Attachment: addition: clean up toolkit-makefiles.sh

Sorry, forgot about this in the original patch - thanks to Neil for reminding me.

Comment 6

[Robert Kaiser]

Comment on attachment 352859 [details] [diff] [review]
addition: clean up toolkit-makefiles.sh

Pushed to trunk as http://hg.mozilla.org/mozilla-central/rev/f86eeb88e4a8 and to branch as http://hg.mozilla.org/releases/mozilla-1.9.1/rev/45be184dfbe8