448771 - Open task context menu in calendar view -> output in error console

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- enable 'Show task in view'
- create a task with start and due date
- open the context menu of this task in the calendar view

RESULT:
=======

- error console output:

Error: Failed to read 'deleteTaskAccesskey' from chrome://calendar/locale/calendar.properties. Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: calGetString :: line 638"  data: no]
Source File: chrome://calendar/content/calUtils.js
Line: 642

moving the mouse to the 'Convert to' entry generates the same error a second time

EXPECTED RESULT:
================

- no error

REPRODUCIBLE:
=============

- always

Comment 1

[Stefan Sitter [:ssitter]]

There only exists "deletetaskAccesskey" but not "deleteTaskAccesskey" in <http://mxr.mozilla.org/mozilla/source/calendar/locales/en-US/chrome/calendar/calendar.properties#437>

To avoid a late-l10n change you probably want to change the calling code to read "deletetaskAccesskey" and fix the entity name after the 0.9 release.

Comment 2

[Martin Schröder [:mschroeder]]

I think we need an late-l10n checkin, or leave it as is for 0.9 because we have to adjust either calendar.properties (1 change), or http://mxr.mozilla.org/seamonkey/source/calendar/base/content/calendar-common-sets.js#504 (change last argument to "task") + calendar.properties (1 change). If we decide to do a late-l10n checkin we should go for solution 1.

sipaq, what's your opinion?

Comment 3

[Simon Paquet [:sipaq]]

An late-l10n change is out of the question for such a small fix, that we can easily work around. Please fix this in calendar-common-sets.js, then file a followup bug. 

Oh, and please set yourself a reminder in Lightning to fix in like seven weeks :)

Comment 4

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Additionally removed superfluous second argument of adaptModificationMenuItem function. Also filed follow-up bug as bug 450391.

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 333537 [details] [diff] [review]
Patch v1

>-function adaptModificationMenuItem(aMenuItemId, aItems, aItemType){
>+function adaptModificationMenuItem(aMenuItemId, aItemType){
While you're at it, please add a space before the {


>-        adaptModificationMenuItem("calendar-item-context-menu-delete-menuitem", items, "Task");
>+        //XXX Workaround added in bug 448771 because of string freeze
>+        var menuItem = document.getElementById("calendar-item-context-menu-delete-menuitem");
I'd suggest to also add a bug# for the followup bug.

r=philipp

Comment 6

[Martin Schröder [:mschroeder]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 7

[Andreas Treumann]

Checked in lightning 2008081803 and sunbird 20080817 -> VERIFIED