448804 - In <test_384370.js> and <test_placesTxn.js>, "Exception / NS_ERROR_FILE_ACCESS_DENIED / nsIFile.remove / head_bookmarks.js / cleanUp", with debug build

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Serge Gautherie (:sgautherie)]

Attachment: test_384370.js.log

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008080101 Minefield/3.1a2pre] (home, debug) (W2Ksp4)

{{
WARNING: EndUpdateBatch without a begin: file .../toolkit/components/places/src/nsNavHistoryResult.cpp, line 4113

*** PASS ***

Exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: ../../../../_tests/xpcshell-simple/test_browser_places/unit/head_bookmarks.js :: cleanUp :: line 132"  data: no]


WARNING: cannot post event if not initialized: file .../netwerk/protocol/http/src/nsHttpConnectionMgr.cpp, line 167

WARNING: nsExceptionService ignoring thread destruction after shutdown: file .../xpcom/base/nsExceptionService.cpp, line 194

[Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIFeedProcessor.onStartRequest]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: file:///.../dist/bin/components/nsLivemarkService.js :: LLL_onStartRequest :: line 993"  data: no]

###!!! ASSERTION: Fastload file should have been closed via xpcom-shutdown: '!mFastLoadTimer', file .../js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 499
}}

Comment 1

[Serge Gautherie (:sgautherie)]

<test_placesTxn.js> has the +/- same issues.

Comment 2

[Robert Strong (they/them - no direct email)]

bah... just hit this today

Comment 3

[Robert Strong (they/them - no direct email)]

btw: the following is just a dump from head_bookmarks.js

Exception: [Exception... "Component returned failure code: 0x80520015
(NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015
(NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame ::
../../../../_tests/xpcshell-simple/test_browser_places/unit/head_bookmarks.js
:: cleanUp :: line 132"  data: no]

It is actually the following which is causing problems in debug builds
[Exception... "Component returned failure code: 0x80040111
(NS_ERROR_NOT_AVAILABLE) [nsIFeedProcessor.onStartRequest]"  nsresult:
"0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame ::
file:///.../dist/bin/components/nsLivemarkService.js :: LLL_onStartRequest ::
line 993"  data: no]

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

These tests need to init nsILivemarkService and nsIFeedProcessor for debug builds. This also makes it so the tests use a profile directory under test_browser_places as the extension manager does to prevent polluting of the bin dir. It now just removes / recreates the profile directory on startup of each test and removes the cleanUp function which will fail when the files are in use (e.g. at end of each test on Windows).

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 334130 [details] [diff] [review]
patch

r=me, thanks

Comment 6

[Robert Strong (they/them - no direct email)]

Checked in to mozilla-central
http://hg.mozilla.org/mozilla-central/index.cgi/rev/6cd9fb678292a96ba20d466c73d00e8d917a9dcf

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080817024436 Minefield/3.1a2pre] (home, debug) (W2Ksp4)

It seems <test_384370.js> (but not <test_placesTxn.js>) was already (fixed/)passing before this patch.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080817081703 Minefield/3.1a2pre] (home, debug default) (W2Ksp4)

V.Fixed

*****

(In reply to comment #3)
> It is actually the following which is causing problems in debug builds
> [Exception... "Component returned failure code: 0x80040111
> (NS_ERROR_NOT_AVAILABLE) [nsIFeedProcessor.onStartRequest]"  nsresult:
> "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame ::
> file:///.../dist/bin/components/nsLivemarkService.js :: LLL_onStartRequest ::
> line 993"  data: no]

Yet, <test_placesTxn.js> still has this exception.
But this would be another bug, as the test passes nonetheless.
(Or the fix regressed/wallpapered the true issue as it is not catching it anymore ??)

What do you think ?

Comment 8

[Robert Strong (they/them - no direct email)]

Looks like the following was what caused that test to fail which is no longer a problem

###!!! ASSERTION: Fastload file should have been closed via xpcom-shutdown: '!mFastLoadTimer', file c:/moz/mozilla-central/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 499

I'm not terribly concerned about the exception as it relates to the test... I'm sure it has to do with it being used under xpcshell where we have to init dependent components, etc.

Having said that... if someone had the time to figure out why it is throwing and fix it I personally would likely approve the fix as long as it didn't add a significant amount of complexity to the test.

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv