449018 - Unifinder: Add a keyboard shortcut (Ctrl+Shift+K) to show and focus "Find events" search pane with filter bar, and include the button in toolbar default set

Status: NEW

(Calendar :: General, enhancement, P3)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- Make unifinder visible
- Press Ctrl+F

RESULT:
=======

- nothing

EXPECTED RESULT:
================

- Focus goes to search bar

REPRODUCIBLE:
=============

- always

Comment 3

[Thomas D. (:thomas8)]

I think the following aspect from duplicate bug 570256 should be added, in line with TB's quick filter bar functionality:

Ctrl+F should also show unifinder if it's currently hidden!

Updated summary accordingly, and rephrased for better retrievability.

Comment 4

[Thomas D. (:thomas8)]

Keyboard shortcuts are vital for efficient use, especially for as basic a functionality as "find / filter" for events (Ctrl+F). Big benefit at low cost, no risk. Recommending as a low-hanging fruit -> flag: wanted-calendar1.0?

Comment 5

[Thomas D. (:thomas8)]

omg, I can't believe this bug still exists!!!

Comment 6

[Thomas D. (:thomas8)]

Alex, can we fix this?

Quite a usability gap for users who need to filter their events regulary.
We should probably also add a toolbar button by default to expose this nice feature more - right now probably nobody knows because it's just tucked away in the menus.

I'm not totally sure about the best (most consistent) keyboard shortcut, candidates are:
Ctrl+K (like global search - maybe best?)
Ctrl+Shift+K (like quick filter - but this is more like searching)
Ctrl+F (mostly used for text search - so probably not useful here, although it's quite memorable)
Ctrl+Shift+F (like Advanced Search Messages - might work, but bit clumsy)

Ideally, these shortcuts should have some consistency across the app.
Btw, we've just lost a shortcut for searching in the Address Book (Ctrl+K up to TB 91).

Comment 7

[Thomas D. (:thomas8)]

^^ comment 6

Comment 8

[Richard Marti (:Paenglab)]

(In reply to Thomas D. (:thomas8) from comment #6)

We should probably also add a toolbar button by default to expose this nice feature more - right now probably nobody knows because it's just tucked away in the menus.

There is a button but not in the default set.

Comment 9

[Alessandro Castellani [:aleca]]

Uh, this is very weird and I never noticed it since I'm not a heavy calendar user.

So, a couple of things that come to mind right away:

• The global search bar should be available in the calendar toolbar by default (so Ctrl+K should be left to that).
• The Find Events search bar feels more like a quick filter for the Calendar, so we might use the same keyboard shortcut.
• The Find Events toggle button should probably be visible by default because, honestly, up until reading this bug I didn't even know I could collapse that panel, which I never use and I'd like to get it out of the way.

I would leave the Ctrl+F shortcut alone since that should be consistently kept for triggering the text search.

Comment 10

[Thomas D. (:thomas8)]

Thanks Alex. So now that we've defined the expected UX for this bug, I think it's ready for consumption by developers.

(In reply to Alessandro Castellani [:aleca] from comment #9)

• The global search bar should be available in the calendar toolbar by default (so Ctrl+K should be left to that).
• The Find Events search bar feels more like a quick filter for the Calendar, so we might use the same keyboard shortcut.

So what Alex is saying boils down to using Ctrl+Shift+K as a calendar quick filter shortcut (same as 3 pane quick filter shortcut). Lgtm.

• I would leave the Ctrl+F shortcut alone since that should be consistently kept for triggering the text search.
• The Find Events toggle button should probably be visible by default because, honestly, up until reading this bug I didn't even know I could collapse that panel, which I never use and I'd like to get it out of the way.

Alex also seems to agree on my idea to make the existing Find Events toggle button available on the toolbar by default.

Comment 11

[Elijah]

So what Alex is saying boils down to using Ctrl+Shift+K as a calendar quick filter shortcut (same as 3 pane quick filter shortcut). Lgtm.

• I would leave the Ctrl+F shortcut alone since that should be consistently kept for triggering the text search.

Ctrl+F is the universally-known Search shortcut, though, and as far as I can tell it doesn't do anything when on the Calendar tab. But I see the reasoning for both options, so how about a compromise: Make a config preference to redefine the keyboard shortcut. Default can be Ctrl+Shift+K, but users will have the option to set it to Ctrl+F or whatever else they like. (It would be an improvement from an accessibility standpoint, too. Could even mark a shift towards making all keyboard shortcuts user-definable via config preferences, but that's out of scope for this issue)