Closed
Bug 449095
Opened 16 years ago
Closed 16 years ago
LoginManagerStorage_legacy shouldn't write file if no data present
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: zpao, Assigned: zpao)
References
Details
Attachments
(1 file)
|
1012 bytes,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
Right now this is blocking bug #288040 - on import from legacy storage of a new profile where no legacy storage files exist, an empty file will be created. This is not expected behavior. Since this is really a bug with the legacy module, it was spun off into a new bug.
Expected behavior: no file is created
Actual behavior: signons3.txt is created
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #332263 -
Flags: review?(dolske)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 332263 [details] [diff] [review]
Patch v0.1
>- this.log("Creating new signons file...");
>- this._writeFile();
>+ this.log(this._signonsFile.path + " does not exist, not creating...");
The path is already logged a few lines up, so this can just be short "no existing file found" message. I"ll fix on commit.
Attachment #332263 -
Flags: review?(dolske) → review+
|
|
||
Comment 3•16 years ago
|
||
Pushed changeset de6fc723c05b
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•