449095 - LoginManagerStorage_legacy shouldn't write file if no data present

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Right now this is blocking bug #288040 - on import from legacy storage of a new profile where no legacy storage files exist, an empty file will be created.  This is not expected behavior. Since this is really a bug with the legacy module, it was spun off into a new bug.

Expected behavior: no file is created
Actual behavior: signons3.txt is created

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 332263 [details] [diff] [review]
Patch v0.1

>-            this.log("Creating new signons file...");
>-            this._writeFile();
>+            this.log(this._signonsFile.path + " does not exist, not creating...");

The path is already logged a few lines up, so this can just be short "no existing file found" message. I"ll fix on commit.

Comment 3

[Justin Dolske [:Dolske]]

Pushed changeset de6fc723c05b