Closed Bug 449146 Opened 15 years ago Closed 15 years ago

Remove dead libsec function declarations

Categories

(NSS :: Libraries, defect, P3)

Product:
NSS
Component:
Libraries
Version:
3.12
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
3.12.1

People

(Reporter: julien.pierre, Assigned: julien.pierre)

References

Details

Attachments

(1 file)

Remove dead code
2.51 KB, patch
nelson
: review+
Details | Diff | Splinter Review 
I stumbled on some dead code while investigating something else. I will attach a patch to remove it.
Priority: -- → P3
Attached patch Remove dead code — — Splinter Review 
These functions only have declarations, but no definitions, and are ifdef'ed out. There is no reason to keep them in the source.
Attachment #332288 - Flags: review?(nelson)
Comment on attachment 332288 [details] [diff] [review]
Remove dead code

Julien, this file contains a large block that is ifdef'ed out with 
#ifdef notdef.
This patch removes about 80% of the declarations in that ifdef'ed 
block.  Why not remove it all?
When I looked at it, it seemed that the other functions that I left in still exist somewhere else. But now that you point this out, it appears these declarations are not necessary. I am OK with removing the whole block.

Comment on attachment 332288 [details] [diff] [review]
Remove dead code

Please remove the whole #ifdef notdef block. Thanks.
Attachment #332288 - Flags: review?(nelson) → review+
Thanks, Nelson. I removed the ifdef block on the trunk.

Checking in certdb/certdb.h;
/cvsroot/mozilla/security/nss/lib/certdb/certdb.h,v  <--  certdb.h
new revision: 1.21; previous revision: 1.20
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.