Last Comment Bug 449146 - Remove dead libsec function declarations
: Remove dead libsec function declarations
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.12
: All All
: P3 normal (vote)
: 3.12.1
Assigned To: Julien Pierre
: 341009 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2008-08-04 18:24 PDT by Julien Pierre
Modified: 2014-04-21 22:05 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Remove dead code (2.51 KB, patch)
2008-08-04 18:26 PDT, Julien Pierre
nelson: review+
Details | Diff | Splinter Review

Description Julien Pierre 2008-08-04 18:24:54 PDT
I stumbled on some dead code while investigating something else. I will attach a patch to remove it.
Comment 1 Julien Pierre 2008-08-04 18:26:46 PDT
Created attachment 332288 [details] [diff] [review]
Remove dead code

These functions only have declarations, but no definitions, and are ifdef'ed out. There is no reason to keep them in the source.
Comment 2 Nelson Bolyard (seldom reads bugmail) 2008-08-04 18:46:00 PDT
Comment on attachment 332288 [details] [diff] [review]
Remove dead code

Julien, this file contains a large block that is ifdef'ed out with 
#ifdef notdef.
This patch removes about 80% of the declarations in that ifdef'ed 
block.  Why not remove it all?
Comment 3 Julien Pierre 2008-08-04 18:56:50 PDT
When I looked at it, it seemed that the other functions that I left in still exist somewhere else. But now that you point this out, it appears these declarations are not necessary. I am OK with removing the whole block.
Comment 4 Nelson Bolyard (seldom reads bugmail) 2008-08-05 21:51:10 PDT
Comment on attachment 332288 [details] [diff] [review]
Remove dead code

Please remove the whole #ifdef notdef block. Thanks.
Comment 5 Julien Pierre 2008-08-06 17:00:32 PDT
Thanks, Nelson. I removed the ifdef block on the trunk.

Checking in certdb/certdb.h;
/cvsroot/mozilla/security/nss/lib/certdb/certdb.h,v  <--  certdb.h
new revision: 1.21; previous revision: 1.20
Comment 6 :Cykesiopka 2014-04-21 22:05:10 PDT
*** Bug 341009 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.