nsHTMLMediaElement::play() doesn't reset properly

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jcranmer, Assigned: cajbir)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
If the playback has ended, then the user agent must set currentLoop to zero and seek to the effective start.

If this involved a seek, the user agent will fire a simple event called timeupdate at the media element.

(quotation from URI listed in the URL field).
(Assignee)

Comment 1

10 years ago
Created attachment 333658 [details] [diff] [review]
Refactoring of playback to fix this bug

First cut at a patch to fix this. Requires patch from bug 449159 to be applied first.
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Depends on: 449159
(Assignee)

Comment 2

10 years ago
Created attachment 340053 [details] [diff] [review]
Second cut at patch 

Change patch to work with bug 449159 changes.
Attachment #333658 - Attachment is obsolete: true
(Assignee)

Comment 3

10 years ago
Created attachment 344016 [details] [diff] [review]
Fix playback after end issues

When playback ends it currently immediately seeks back to the beginning of the file. This patch fixes it so it does this when playback is next requested instead.

The included tests have a time check commented out. These will be uncommented when bug 460871 is done. It relies on a fix in that bug. That bug also relies on the fix in this bug so I had to pick one to have the test commented out.
Attachment #340053 - Attachment is obsolete: true
Attachment #344016 - Flags: superreview?(roc)
Attachment #344016 - Flags: review?(roc)
(Assignee)

Updated

10 years ago
Blocks: 460871
Attachment #344016 - Flags: superreview?(roc)
Attachment #344016 - Flags: superreview+
Attachment #344016 - Flags: review?(roc)
Attachment #344016 - Flags: review+
(Assignee)

Comment 4

10 years ago
http://hg.mozilla.org/mozilla-central/rev/b44fe4f84e1d
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.