449168 - [FIX]HasSelectionOverflowingDecorations leaks selection details

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

The return value of GetSelectionDetails needs to be deleted, and in this case it's not.

Patch coming up.  Still looking for a good way to test it.  Masayuki, do you think you can write a test that will exercise this loop?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 332307 [details] [diff] [review]
Fix

Thank you, but I hope there is auto release way...

And I have no idea for testing this.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Well.. why was this code added?  When is it ever exercised?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #2)
> Well.. why was this code added?  When is it ever exercised?

Some IME selection has overflowed underline, e.g., on Mac, the selections have thick underline in default settings. Therefore, the loop is only used on Mac when IME is composing. (Of course, IME selection style is changed by prefs, you can run the loop on other platforms too.)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmm.  I'm on Mac!  Is there a way to trigger IME programmatically?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm not sure. We don't have any IME automated tests.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Pushed changeset b5295239bdba.

Comment 7

[Dave Townsend [:mossop]]

Backed out as part of the investigation into bug 450401

Comment 8

[Justin Dolske [:Dolske]]

Relanded.