[FIX]"ASSERTION: media list must be nonempty"

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

({assertion, testcase})

Trunk
x86
Mac OS X
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
Created attachment 332311 [details]
testcase

###!!! ASSERTION: media list must be nonempty: 'media->Count() != 0', file /Users/jruderman/central/layout/style/nsCSSParser.cpp, line 1838
This assertion should just be removed (and maybe also for @import).  In the new media query world, |@media {}| is equivalent to |@media all {}|.
Created attachment 335581 [details] [diff] [review]
Like so

Is the change in behavior for @media correct here, though? Neither Opera nor Safari seem to allow @media with no media, but they might not implement this part of media queries yet, I guess.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #335581 - Flags: superreview?(dbaron)
Attachment #335581 - Flags: review?(dbaron)
Summary: "ASSERTION: media list must be nonempty" → [FIX]"ASSERTION: media list must be nonempty"
Comment on attachment 335581 [details] [diff] [review]
Like so

r+sr=dbaron
Attachment #335581 - Flags: superreview?(dbaron)
Attachment #335581 - Flags: superreview+
Attachment #335581 - Flags: review?(dbaron)
Attachment #335581 - Flags: review+
Pushed changeset 47e1265cbf69.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

Comment 5

8 years ago
This reftest is failing for Fedora unit tests (see bug 560882).
I have machines available to help fixing it.
Let me know if it should make sense to file another bug instead of reopening this one.
Blocks: 560882
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Please file new bugs on new issues.  This bug is fixed.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.