449327 - nsSVGForeignObjectFrame::GetBBox should account for canvas TM

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Summary says it all.

Comment 1

[Mats Palmgren (inactive)]

Comment on attachment 332490 [details] [diff] [review]
fix

Please decide if we should "*_retval = nsnull" before returning
an error or not.  The method should be internally consistent.

sr=mats with that

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 332490 [details] [diff] [review]
fix


Would you mind writing a mochitest for this? Something we can extend to cover <text>, pathGeometry i.e. <rect> and containers i.e. <g> although I'd be happy with just foreignObject for now.

Comment 3

[Robert Longson [:longsonr]]

(In reply to comment #1)
> (From update of attachment 332490 [details] [diff] [review])
> Please decide if we should "*_retval = nsnull" before returning
> an error or not.  The method should be internally consistent.
> 

It should include that line.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't know how to write a mochitest for this. getBBox() doesn't work because it returns coordinates "in the current user space" i.e. ignoring transforms applied to the foreignObject. I have written a getBBox mochitest though, and we may as well land it, even though it doesn't test this particular bug.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: updated for comments

Comment 6

[Robert Longson [:longsonr]]

This landed, shouldn't it be marked fixed?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes.