449371 - latest thunderbird crashed when exiting on OpenSolaris

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Boying Lu]

Thunderbird failed to be launched on OpenSolaris.

Comment 1

[Boying Lu]

(In reply to comment #0)
> Thunderbird failed to be launched on OpenSolaris.
> 
Sorry my mistake, It should be Thunderbird crashed when exiting.

The root cause is in following snippet:
nsresult
nsScreenManagerGtk :: Init()
{
   ...
    // get the number of screens via xinerama
    if (_XnrmIsActive && _XnrmQueryScreens &&
        _XnrmIsActive(GDK_DISPLAY())) {
      screenInfo = _XnrmQueryScreens(GDK_DISPLAY(), &numScreens);
    }
   ...
}

On OpenSolaris, when XineramaIsActive() is called, it will register the address of close_display() in X, so it will be called when XCloseDisplay() is called

But before XCloseDisplay() is called, the following deconstructor is called

nsScreenManagerGtk :: ~nsScreenManagerGtk()
{
  ...
  if (mXineramalib && mXineramalib != SCREEN_MANAGER_LIBRARY_LOAD_FAILED) {
    PR_UnloadLibrary(mXineramalib);
  }
  ...
}
So, libXinerama.so is unloaded and the function address registered 
in X (i.e. close_display()) is invalid when XCloseDisplay() is called

This causes thunderbird crashes.

Comment 2

[Boying Lu]

Attachment: patch

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 332513 [details] [diff] [review]
patch

This is fine, but please put a comment above the #if explaining what you explained in the previous comment, so that people reading this code in the future know why the library isn't unloaded on solaris.

Comment 4

[Boying Lu]

Attachment: patch with comments

Comment 6

[Frank Wein [:mcsmurf]]

This patch does not apply anymore. Can you attach a new version?

Comment 7

[Boying Lu]

Attachment: new patch based on latest trunk code

Comment 8

[Ginn Chen]

Pushed with a small change to comment line
http://hg.mozilla.org/index.cgi/mozilla-central/rev/784bd07695bc