Closed Bug 449458 Opened 16 years ago Closed 8 years ago

Extend jsdIFilter coverage to include jsdIScriptHook

Categories

(Core :: JavaScript Engine, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: johnjbarton, Unassigned)

References

Details

At present jsiDebuggerService offers the ability to "filter" callbacks. This ability is not used in Firebug because of the issues discussed in bug 449454 requires us to mix jsdIExceptionHook (which is filtered) and jsdIScriptHook (which is not). 

By extending jsdIFilter to cover jsIScriptHook, Firebug might be able to implement true page-focused debugging. Currently Firebug simulates page-focused debugging by telling the user that the debugger is "enabled for a site", but in fact some of the code runs for all sites all of the time because we have no way to control jsd on a per/site basis.

This change could potentially break users of jsdIFilter by changing the semantic to include jsdIScriptHook. However, to the best of my knowledge there aren't any users of jsdIFilter and extending the filter in this way would as likely help as harm them.

Test case should be constructed first in this case, since we have zero experience with jsdIFilter as it stands day.  The test case would be
 component to hook the jsd interface, both one that we expect to be filtered and new ones we want to filter.
 open window to shove code into jsd.
 string output of hooks can be tested, first to show the filter is working and then to be the build test.
Component: General → JavaScript Debugger
Product: Firefox → Other Applications
Version: unspecified → Trunk
QA Contact: general → venkman
Component: Venkman JS Debugger → JavaScript Debugging APIs
Product: Other Applications → Core
QA Contact: venkman → jsd
Summary: [jsd] Extend jsdIFilter coverage to include jsdIScriptHook → Extend jsdIFilter coverage to include jsdIScriptHook
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
JSD was removed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.