Closed
Bug 449506
Opened 17 years ago
Closed 17 years ago
Expose the places db connection
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
6.77 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
It turns out we need to use the database connection not from c++ sometimes, so we need a way to get to it.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #332633 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch][needs review dietrich]
|
||
Comment 2•17 years ago
|
||
Comment on attachment 332633 [details] [diff] [review]
v1.0
r=me, but please add a test.
|
|
||
Updated•17 years ago
|
Attachment #332633 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
(In reply to comment #2)
> (From update of attachment 332633 [details] [diff] [review])
> r=me, but please add a test.
Testing would be done with the patch in bug 444763. Is that sufficient, or would you like another one (our tests will fail without using it).
Alternatively, I can pull those test changes into this bug.
Whiteboard: [has patch][needs review dietrich] → [has patch][has review]
|
|
Assignee | |
Comment 4•17 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/738e0f6f0308
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
|
|
Assignee | |
Comment 5•17 years ago
|
||
Tests in this changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/bc658ebc5c77
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•