449508 - update geolocation code to editor's draft [DATE: 20 June 2008]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

Much of these changes are related to the renaming of geolocation -> geoposition, and geolocator -> geolocation.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 332636 [details] [diff] [review]
patch v.1

jst, please ignore the changes to plugin and libpr0n.  Those changes are for another, totally unrelated, bug.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 332636 [details] [diff] [review]
patch v.1

Please use "hg mv" to rename the files that are renamed here.

- In nsGeolocationRequest::Allow():

+  if (NS_FAILED(rv)) {
+
+    if (!mErrorCallback)
+      return NS_OK;  // If no one is listening for errors, fail silently.
[...]
+    callbackProxy->HandleEvent(positionError);
+    return rv;

I don't get why whether there's a error callback should have an impact on the return value from this method.

r+sr=jst with that sorted out.

Comment 3

[Doug Turner (:dougt)]

good catch jst.  i will make that a return NS_OK.

i will also do hg move/rename instead of the hg remove + hg add.

Comment 4

[Doug Turner (:dougt)]

dougt
Thu Aug 14 16:36:02 2008 +0000	37392cb236bc	bug 449508. update geolocation code to editor's draft. r+sr=jst

jst.  hg rename caused me a bunch of pain.  Since blame was just me on the last files, i did the remove+add.  Sorry.  If there was more blame, i would have tried harder to resolve this issue.