449518 - Video autostart after doing Back/Forward history button on browser

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Biju]

Video automatically start after doing Back button on browser and then coming back by pressing Forward button on browser.

This also happens if we navigates away from a page with not started video


Steps:
1. ensure Javascript is enabled
2. Goto URL http://simon.html5.org/test/html/semantics/video/
3. click link for 002.htm  
4. wait for both video to appear as STOPPED
5. press back button on browser
6. press FORWARD BUTTON on browser to reach 002.htm  

Result:-
Video start playing,

Expected:-
Video should not play.

Comment 1

[cajbir (:cajbir)]

Attachment: Keep track of pause state when entering/returning form bfcache

Comment 2

[cajbir (:cajbir)]

Requires patch from bug 457964 due to change in paused attribute type

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think we should be involving nsVideoFrame here. StopVideoInstance should just operate directly on the content (right now I think display:none content won't be freezing/thawing properly). So it's probably best if nsHTMLMediaElement just has Freeze and Thaw methods and saves its state internally.

Comment 4

[cajbir (:cajbir)]

Attachment: Address review comments

Address review comments

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  // Handle moving into and out of the bfcache by pausing and playing
+  // as needed.
+  NS_IMETHOD Freeze();
+  NS_IMETHOD Thaw();

These don't need to be virtual.

+#ifdef MOZ_MEDIA
+    EnumeratePlugins(domDoc, NS_LITERAL_STRING("video"), StopMediaInstance);
+#endif

Shouldn't we enumerate audio elements here too?

+  nsHTMLMediaElement* element = (nsHTMLMediaElement*)aContent;

static_cast

Comment 7

[cajbir (:cajbir)]

Attachment: Address additional review comments

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It seems that elements that aren't in the document, but are playing audio, won't get frozen and will keep playing while in the bfcache. I guess we should have a separate bug on that.

Comment 9

[cajbir (:cajbir)]

This was also raised in bug 454971 comment 10. Maybe fix it as part of that bug?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sure.

Comment 11

[cajbir (:cajbir)]

http://hg.mozilla.org/mozilla-central/rev/bb3a920e7cfe